MRG: do a single pass reverse complement in kmers_and_hashes
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Adamtaranto
added a commit
that referenced
this pull request
Oct 28, 2024
* Make kmers_and_hashes iterable * Suppress blank output with skip_bad_kmers * update tests to pick up stderr warning instead of PyValueError. Change skip_bad_kmers behaviour. * Implement hash_to_kmer map + unhash() * Tests for count and consume with kmer tracking enabled * rm blank test * Add tests for canon() * Style fixes by Ruff * remove unused tests * Add dump_kmers() * Add tests for dump_kmers() * unsorted dump_kmers() will produce randomly ordered output. Remove from tests. * skip kmers that exist in hash_to_kmer but are missing from count table after being dropped * Add tests for dump_kmers() on KmerCountTables with dropped count records * Style fixes by Ruff * back to action token * disable ruff formatting on dependabot commits * MRG: do a single pass reverse complement in `kmers_and_hashes` (#82) * compute revcomp once, not every time * rm comment * run cargo fmt --------- Co-authored-by: Adamtaranto <[email protected]> Co-authored-by: C. Titus Brown <[email protected]> ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: PR into #70
Easier than I thought 😅