Revert renaming method onMaster() and offMaster() in interface LocalNodeMasterListener

[tlfeng]

Description

Revert renaming method onMaster() and offMaster() in interface LocalNodeMasterListener

I didn't realize that the onMaster() and offMaster() is exposed to the public, then renamed it directly to make the method name inclusive. The classes that implement the interface need to implement the method in new name, so it breaks backwards compatibility.
The original file: https://github.com/opensearch-project/OpenSearch/blob/2.0.1/server/src/main/java/org/opensearch/cluster/LocalNodeMasterListener.java

Issues Resolved

#3688

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

❌   Gradle Check failure 6711160
Log 6281

Reports 6281

[tlfeng]

In log 6281:

> Task :plugins:repository-s3:yamlRestTest

REPRODUCE WITH: ./gradlew ':plugins:repository-s3:yamlRestTest' --tests "org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT.test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials}" -Dtests.seed=7AAB1C43DFD5610D -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=el-GR -Dtests.timezone=Europe/Busingen -Druntime.java=17 -Dtests.rest.denylist=repository_s3/30_repository_temporary_credentials/*,repository_s3/40_repository_ec2_credentials/*,repository_s3/50_repository_ecs_credentials/*,repository_s3/60_repository_eks_credentials/*

org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT > test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials} FAILED
    java.lang.AssertionError: Failure at [repository_s3/20_repository_permanent_credentials:257]: expected [2xx] status code but api [snapshot.delete] returned [500 Internal Server Error] [{"error":{"root_cause":[{"type":"repository_exception","reason":"[repository_permanent] concurrent modification of the index-N file, expected current generation [5761] but it was not found in the repository","stack_trace":"RepositoryException[[repository_permanent] concurrent modification of the index-N file, expected current generation [5761] but it was not found in the repository]\n\tat org.opensearch.repositories.blobstore.BlobStoreRepository.ensureSafeGenerationExists(BlobStoreRepository.java:2142)\n\tat org.opensearch.repositories.blobstore.BlobStoreRepository.lambda$writeIndexGen$55(BlobStoreRepository.java:2023)\n\tat org.opensearch.action.ActionListener$1.onResponse(ActionListener.java:80)\n\tat org.opensearch.common.util.concurrent.ListenableFuture$1.doRun(ListenableFuture.java:126)\n\tat 
...

[tlfeng]

start gradle check

[tlfeng]

This PR has been backported to 2.1 branch in PR #3687 / commit 8aadcc0

[opensearch-ci-bot]

✅   Gradle Check success 6711160
Log 6289

Reports 6289

[saratvemulapalli]

@tlfeng do you want to revert this main?
I understand it makes sense for 2.x line.

[tlfeng]

@saratvemulapalli I want to merge in main as well to reduce the code difference between branches, and it will make me have a clear mind on the whole process 😄.
Besides, there is a chance that the non-inclusive public Java API will not be removed in version 3.0, so I think making this part of code the same on all branches is better.

[tlfeng]

@saratvemulapalli Thanks a lot for your review! 👍

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3686-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 722a8b9977a32a9947f0770d4958c861ab7be7a1
# Push it to GitHub
git push --set-upstream origin backport/backport-3686-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3686-to-2.x.