Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] Revert renaming method onMaster() and offMaster() in interface LocalNodeMasterListener #3687

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Jun 23, 2022

Description

Backport PR #3686 to 2.1 branch.

Revert renaming method onMaster() and offMaster() in interface LocalNodeMasterListener

I didn't realize that the onMaster() and offMaster() is exposed to the public, then renamed it directly to make the method name inclusive. The classes that implement the interface need to implement the method in new name, so it breaks backwards compatibility.
The original file: https://github.com/opensearch-project/OpenSearch/blob/2.0.1/server/src/main/java/org/opensearch/cluster/LocalNodeMasterListener.java

Issues Resolved

#3688

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng changed the title Restore renaming method onMaster() and offMaster() in interface LocalNodeMasterListener [2.1] Restore renaming method onMaster() and offMaster() in interface LocalNodeMasterListener Jun 23, 2022
@tlfeng tlfeng changed the title [2.1] Restore renaming method onMaster() and offMaster() in interface LocalNodeMasterListener [2.1] Revert renaming method onMaster() and offMaster() in interface LocalNodeMasterListener Jun 23, 2022
@tlfeng tlfeng marked this pull request as ready for review June 24, 2022 00:10
@tlfeng tlfeng requested review from a team and reta as code owners June 24, 2022 00:10
@tlfeng tlfeng added bug Something isn't working backwards-compatibility v2.1.0 Issues and PRs related to version 2.1.0 backport PRs or issues specific to backporting features or enhancments labels Jun 24, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d0ea8e6
Log 6283

Reports 6283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments backwards-compatibility bug Something isn't working v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants