[2.x] Revert renaming method onMaster() and offMaster() in interface LocalNodeMasterListener #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odeMasterListener (opensearch-project#3686) Signed-off-by: Tianli Feng <[email protected]>
tlfeng
added
bug
VachaShah
approved these changes
Jun 24, 2022
|
@VachaShah Thanks for your review! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport PR #3686 to
2.xbranch.onMaster()andoffMaster()in interfaceLocalNodeMasterListeneronMaster()andoffMaster()were renamed directly to make the method name inclusive. However they are exposed to the public, then the classes that implement the interface need to implement the method in new name, so it breaks backwards compatibility.The original file: https://github.com/opensearch-project/OpenSearch/blob/2.0.1/server/src/main/java/org/opensearch/cluster/LocalNodeMasterListener.java
Issues Resolved
#3688
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.