Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] type support from Bulk API #2215

Merged
merged 4 commits into from
Feb 23, 2022
Merged

[Remove] type support from Bulk API #2215

merged 4 commits into from
Feb 23, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Feb 22, 2022

Removes all support for type parameter from the Bulk API.

relates #1940

@nknize nknize added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues Indexing & Search labels Feb 22, 2022
@nknize nknize requested a review from a team as a code owner February 22, 2022 19:32
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 0ec76c6a190dc1e629936246865b564a46d9e9da
Log 2709

Reports 2709

@nknize nknize force-pushed the remove/typesFromBulk branch from 0ec76c6 to fbd5364 Compare February 22, 2022 20:12
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure fbd53641017ea24d39c559f12276004457cffb4f
Log 2714

Reports 2714

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 5c6f7b02d0eb78f7c22522246650eabaa6b61706
Log 2734

Reports 2734

@nknize
[Remove] type support from Bulk API
8d7fd9c 
Removes all support for type parameter from the Bulk API.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize
fix bwc tests
525fb67 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize
fix FCR bwc failures
68e1f0d 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize
fix more rando test failures
c58d994 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize force-pushed the remove/typesFromBulk branch from da63423 to c58d994 Compare February 23, 2022 05:49
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success c58d994
Log 2736

Reports 2736

dreamer-89
dreamer-89 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking up this task.

@nknize nknize merged commit 1b571ec into opensearch-project:main Feb 23, 2022
@nknize nknize mentioned this pull request Feb 25, 2022
Closed
67 tasks
@dreamer-89 dreamer-89 mentioned this pull request Feb 25, 2022
Merged
@saratvemulapalli saratvemulapalli mentioned this pull request Mar 15, 2022
Closed
10 tasks
This was referenced Jun 3, 2022
Merged
Merged
@Ahmad-Faizan Ahmad-Faizan mentioned this pull request Dec 16, 2022
Closed
@mantas-sidlauskas mantas-sidlauskas mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamer-89 dreamer-89 dreamer-89 approved these changes

Assignees
No one assigned
Labels
Indexing & Search non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @opensearch-ci-bot @dreamer-89