-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Type removal] Ignore _type field in bulk request #3505
Conversation
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
72773de
to
69d1886
Compare
❌ Gradle Check failure 72773de73f84102681cf9ac86066785cad078246 |
Gradle check job #5766 has three test failures but still reported success. Opened #3506
All failures happens on
|
start gradle check |
Failure is not reproducible when specific test/task is run. Refiring
|
@dreamer-89 I thought |
Yeah, it's causing enough pain for folks that I think it's worth it to put in this bit of no-opery until we can get to a better medium and long term solution. It doesn't mean we'll take our foot off the gas API version, but I don't want people to be broken on 2.x until we do. Thanks, |
start gradle check |
Tests are essentially flaky and passes on retries. Verified this on local run (report snapshot and zip attached below). Ran gradle check with scan option to get more detailed output, which shows that tests are marked flaky and succeeded on retry. Complete report: |
On first run with gradle check scan, type related tests are failing with
|
Ran more scans and had similar pattern as above. |
Like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for verifying this. Hopefully we can get REST Version API in by 2.2 to make this easier for the rest of the 2.x line.
Let's get the endpoints taken care of in a separate PR.
A quick update, I was able to reproduce the issue with filebeats (system module enabled) and OpenSearch 2.0. Verified that with this fix, filebeats process wasn't throwing any exceptions and was able to log events on OpenSearch engine. Before fix
After fix
|
…-project#3505)" This reverts commit a93ff13.
* Revert "Revert removal of typed end-points for bulk, search, index APIs (#3524)" This reverts commit f48043b. * Revert "[Type removal] Ignore _type field in bulk request (#3505)" This reverts commit a93ff13. Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: Nicholas Walter Knize <[email protected]>
Has this made it into a released version yet? I'm still seeing issues with 2.1.0. |
Hi @opoplawski, Thanks for checking in. The actual issue was version incompatibility b/w OpenSearch 2.0 & external clients (filebeat etc, please check #3484) and was mitigated by fix. Clients need to override override_main_response_version setting as mentioned here. Please let me know if you are still seeing any issues. |
Ah, didn't realize that setting override_main_response_version was a needed part of the fix. With that in place, my winlogbeat 7.12 clients are happy. Logstach with opensearch output plugin reports:
but hopefully that won't cause any issues. |
Description
Related #3504
#3484
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.