Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Breaking changes in 2.0 #2480

Closed
10 tasks done
saratvemulapalli opened this issue Mar 15, 2022 · 9 comments
Closed
10 tasks done

[Documentation] Breaking changes in 2.0 #2480

saratvemulapalli opened this issue Mar 15, 2022 · 9 comments
Labels
>breaking Identifies a breaking change. Meta Meta issue, not directly linked to a PR v2.0.0 Version 2.0.0

Comments

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Mar 15, 2022 •
edited
Loading

This is a meta issue which lists down all breaking changes in OpenSearch 2.0

Inclusive Naming

Concerning changes

Type Changes:

Concerning changes

Example Changes in plugins

opensearch-project/asynchronous-search#110

Lucene 9 upgrade

Gradle 7 upgrade

Example Changes in plugins

opensearch-project/job-scheduler#133

Deprecated code in 2.0+

Concerning changes

JDK Support

Settings Changes
@saratvemulapalli saratvemulapalli added bug Something isn't working v2.0.0 Version 2.0.0 >breaking Identifies a breaking change. labels Mar 15, 2022
@saratvemulapalli saratvemulapalli mentioned this issue Mar 15, 2022
Closed
3 tasks
@saratvemulapalli saratvemulapalli added the Meta Meta issue, not directly linked to a PR label Mar 16, 2022
@saratvemulapalli saratvemulapalli mentioned this issue Mar 21, 2022
Closed
@CEHENKLE CEHENKLE removed the bug Something isn't working label Mar 21, 2022
@Naarcha-AWS Naarcha-AWS mentioned this issue Mar 23, 2022
Closed
@cliu123
Copy link
Member

cliu123 commented Mar 24, 2022 •
edited
Loading

Security plugin breaking changes:

  • Security plugin will drop the rolling upgrade support ODFE -> OpenSearch 1.2.0, but will still support the upgrade patch ODFE 1.13 -> OpenSearch 1.x -> OpenSearch 2.0.0
  • Security plugin no longer supports configuration migration DynamicConfigModelV6 -> DynamicConfigModelV7.

Security Dashboards plugin breaking changes:

  • Enforce authentication on api/status by default. Request to api/status API is required to provide valid credential unless it's explicitly configured to bypass authentication(opensearch_security.auth.unauthenticated_routes: ['/api/reporting/stats', '/api/status']).

@brijos
Copy link

brijos commented Mar 28, 2022

Destination API will break in 2.0 - opensearch-project/alerting#105

This was referenced Mar 30, 2022
Merged
Closed
@brijos brijos mentioned this issue Apr 4, 2022
Closed
@VachaShah VachaShah mentioned this issue Apr 11, 2022
Merged
1 task
@travisbenedict
Copy link

Are there any breaking changes related to the expression scripting language?

I ran tests for OpenSearch 2.0 using OpenSearch Benchmark and was receiving errors for this query which uses expression scripting. The error message was:

"error-description": "search_phase_execution_exception ({'error': {'root_cause': [{'type': 'illegal_argument_exception', 'reason': 'Unsupported api 589824'}], 'type': 'search_phase_execution_exception', 'reason': 'all shards failed', 'phase': 'query', 'grouped': True, 'failed_shards': [{'shard': 0, 'index': 'geonames', 'node': 'G2m1_1_mR0qqSCHaYUiwMA', 'reason': {'type': 'query_shard_exception', 'reason': 'script_score: the script could not be loaded', 'index': 'geonames', 'index_uuid': 'sXxM4QaDSlGryh1Slg5pbg', 'caused_by': {'type': 'illegal_argument_exception', 'reason': 'Unsupported api 589824'}}}], 'caused_by': {'type': 'illegal_argument_exception', 'reason': 'Unsupported api 589824'}}, 'status': 400})"

All other operations for all other OpenSearch Benchmark workloads were successful. I also tested against OpenSearch 1.3 and did not receive this error.

More information can be found in opensearch-project/opensearch-benchmark-workloads#41

@dlvenable
Copy link
Member

@saratvemulapalli , Thank you for putting this together. Can you add this to the public roadmap so that it is clearly discoverable? It took a little bit of searching for me to find this.

@CEHENKLE
Copy link
Member

@saratvemulapalli , Thank you for putting this together. Can you add this to the public roadmap so that it is clearly discoverable? It took a little bit of searching for me to find this.

Done. https://github.com/orgs/opensearch-project/projects/1

@dblock
Copy link
Member

dblock commented Apr 21, 2022

In #3031, override_main_response_version has been removed.

@peternied
Copy link
Member

@saratvemulapalli Great work assembling this all in one spot, from @dlvenable comment it seems like we might want to amp up the visibility on these items. @elfisher @stockholmux Do we know all the places we are going to put this information? Seems like making it part of the release notes for 2.0.0, opensearch.org website and our documentation are appropriate.

@seanneumann
Copy link

Breaking changes for OpenSearch Dashboards can be found in the Dashboards Release notes for 2.0

@bbarani bbarani changed the title [BUG] Breaking changes in 2.0 [Documentation] Breaking changes in 2.0 May 4, 2022
@cliu123 cliu123 mentioned this issue May 12, 2022
Closed
This was referenced May 17, 2022
Merged
Merged
@saratvemulapalli
Copy link
Member Author

Closing this issue as 2.0 is out.

Yury-Fridlyand added a commit to Bit-Quill/opensearch-net that referenced this issue Jun 9, 2022
@Yury-Fridlyand
Rename master node role to cluster_manager as it was done in Open…
fbd850d 
…Search.

Ref: opensearch-project/OpenSearch#2480

Signed-off-by: Yury Fridlyand <[email protected]>
Yury-Fridlyand added a commit to Bit-Quill/opensearch-net that referenced this issue Jun 9, 2022
@Yury-Fridlyand
Remove tests for _type validation in mapping APIs as it was removed…
a021357 
… from `OpenSearch`.

Ref: opensearch-project/OpenSearch#2238 opensearch-project/OpenSearch#2480

Signed-off-by: Yury Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this issue Jun 9, 2022
Merged
Yury-Fridlyand added a commit to Bit-Quill/opensearch-net that referenced this issue Aug 29, 2022
@Yury-Fridlyand
Add OpenSearch 2.0 support to .Net client.
234b745 
* Update nuget packages (opensearch-project#88)
* Cleanup - removing stale dependencies.
* Fix 2 typos in scripts project
* Update `scripts` project file to include all relevant objects.
* Rename `master` node role to `cluster_manager` as it was done in OpenSearch.
    Ref: opensearch-project/OpenSearch#2480
* Remove validation for indices segments stats.
    `OpenSearch` 2.0 uses newer version of `Lucene` (9.0) which doesn't provide segments stats info.
    Ref: opensearch-project/OpenSearch#2029 opensearch-project/OpenSearch#1109
    See also history for `server/src/main/java/org/opensearch/index/engine/SegmentsStats.java` in `OpenSearch` repo.
* Remove tests for `_type` validation in mapping APIs as it was removed from `OpenSearch`.
    Ref: opensearch-project/OpenSearch#2238 opensearch-project/OpenSearch#2480
* Remove usage of deprecated `search.remote` settings.
    Ref: opensearch-project/OpenSearch#1870
* Update abstractions package - patch to support OpenSearch 2.0. Update integration workflow to run tests on OpenSearch 2.0.
* Rename `master_timeout` to `cluster_manager_timeout` in all APIs where it is used.
* Enrich comments to already renamed `CatMaster`/`CatClusterManager` API.
* Rename in `/_cluster/stats`/`cluster.stats` and `/_cluster/state`/`cluster.state`.
* Add deprecation info.
* Rename in comments.
* Rename in test data.
* Renamings in tests including `MasterEligible`, but mark it is obsolete.
* Rename branch reference in scripting.
* Mark `indices.exists_type`/`TypeExists` APIs as deprecated.
* Update compatibility matrix and include it into `sln` file.
* Add deprecation notice to all reference of `include_type_name`/`IncludeTypeName`.
* Update compatibility matrix.
* Remove `OpenDistro` compatibility notice.
* Update repo link.
* Add small README for each project being released.
* Address PR opensearch-project#51 feedback.

Signed-off-by: Yury-Fridlyand <[email protected]>
wbeckler pushed a commit to opensearch-project/opensearch-net that referenced this issue Aug 31, 2022
@Yury-Fridlyand
Add OpenSearch 2.0 support to .Net client. (#51)
835c266 
* Update nuget packages (#88)
* Cleanup - removing stale dependencies.
* Fix 2 typos in scripts project
* Update `scripts` project file to include all relevant objects.
* Rename `master` node role to `cluster_manager` as it was done in OpenSearch.
    Ref: opensearch-project/OpenSearch#2480
* Remove validation for indices segments stats.
    `OpenSearch` 2.0 uses newer version of `Lucene` (9.0) which doesn't provide segments stats info.
    Ref: opensearch-project/OpenSearch#2029 opensearch-project/OpenSearch#1109
    See also history for `server/src/main/java/org/opensearch/index/engine/SegmentsStats.java` in `OpenSearch` repo.
* Remove tests for `_type` validation in mapping APIs as it was removed from `OpenSearch`.
    Ref: opensearch-project/OpenSearch#2238 opensearch-project/OpenSearch#2480
* Remove usage of deprecated `search.remote` settings.
    Ref: opensearch-project/OpenSearch#1870
* Update abstractions package - patch to support OpenSearch 2.0. Update integration workflow to run tests on OpenSearch 2.0.
* Rename `master_timeout` to `cluster_manager_timeout` in all APIs where it is used.
* Enrich comments to already renamed `CatMaster`/`CatClusterManager` API.
* Rename in `/_cluster/stats`/`cluster.stats` and `/_cluster/state`/`cluster.state`.
* Add deprecation info.
* Rename in comments.
* Rename in test data.
* Renamings in tests including `MasterEligible`, but mark it is obsolete.
* Rename branch reference in scripting.
* Mark `indices.exists_type`/`TypeExists` APIs as deprecated.
* Update compatibility matrix and include it into `sln` file.
* Add deprecation notice to all reference of `include_type_name`/`IncludeTypeName`.
* Update compatibility matrix.
* Remove `OpenDistro` compatibility notice.
* Update repo link.
* Add small README for each project being released.
* Address PR #51 feedback.

Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>
@phillbaker phillbaker mentioned this issue Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>breaking Identifies a breaking change. Meta Meta issue, not directly linked to a PR v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@dlvenable @dblock @seanneumann @peternied @travisbenedict @cliu123 @saratvemulapalli @CEHENKLE @brijos