Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Workspace] Enable direct query connections to support in workspace #8010

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[Backport 2.x] [Workspace] Enable direct query connections to support in workspace #8010

merged 1 commit into from
Sep 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0798865 from #7839.

@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports all-star-contributor workspace v2.17.0 labels Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.60%. Comparing base (4c64d81) to head (f2c0686).
Report is 12 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ents/workspace_detail/select_data_source_panel.tsx 80.64% 2 Missing and 4 partials ⚠️
src/plugins/workspace/public/utils.ts 73.91% 6 Missing ⚠️
...workspace_detail/association_data_source_modal.tsx 90.00% 3 Missing and 2 partials ⚠️
.../workspace_detail/data_source_connection_table.tsx 96.49% 1 Missing and 1 partial ⚠️
...ts/workspace_form/direct_query_connection_icon.tsx 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #8010      +/-   ##
==========================================
+ Coverage   60.58%   60.60%   +0.02%     
==========================================
  Files        3726     3727       +1     
  Lines       88186    88290     +104     
  Branches    13624    13651      +27     
==========================================
+ Hits        53425    53512      +87     
- Misses      31516    31528      +12     
- Partials     3245     3250       +5
Flag Coverage Δ
Linux_1 28.73% <87.50%> (+0.08%) ⬆️
Linux_2 56.36% <ø> (ø)
Linux_3 37.44% <ø> (ø)
Linux_4 29.72% <ø> (ø)
Windows_1 28.74% <87.50%> (+0.08%) ⬆️
Windows_2 56.31% <ø> (ø)
Windows_3 37.44% <ø> (-0.01%) ⬇️
Windows_4 29.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe mentioned this pull request Sep 5, 2024
Closed
7 tasks
@github-actions @opensearch-changeset-bot
@Kapian1234 @wanglam @ruanyl @SuZhou-Joe
[Workspace] Enable direct query connections to support in workspace (#…
f2c0686 
…7839)

* add dqc

Signed-off-by: yubonluo <[email protected]>

* add dircet query connections on the detail page

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #7839 created/updated

* delete useless code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* Refactor association modal

Signed-off-by: Kapian1234 <[email protected]>

* Integrate modal with workspace detail page

Signed-off-by: Lin Wang <[email protected]>

* Fix parent data source unchecked

Signed-off-by: Lin Wang <[email protected]>

* Remove all tab and sort connections by name alphabetical

Signed-off-by: Lin Wang <[email protected]>

* optimzie

Signed-off-by: yubonluo <[email protected]>

* Fix checked status disappear after modal tab change

Signed-off-by: Lin Wang <[email protected]>

* optimize the dqc table

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* update the table css

Signed-off-by: yubonluo <[email protected]>

* Simplify options update logic

Signed-off-by: Lin Wang <[email protected]>

* Add unit tests for AssociationDataSourceModal

Signed-off-by: Lin Wang <[email protected]>

* add unit test

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* Add nested support in associate data source modal

Signed-off-by: Lin Wang <[email protected]>

* delete useless code

Signed-off-by: yubonluo <[email protected]>

* Change back type

Signed-off-by: Lin Wang <[email protected]>

* Update type in modal UT

Signed-off-by: Lin Wang <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kapian1234 <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
(cherry picked from commit 0798865)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-7839-to-2.x branch from d0633f7 to f2c0686 Compare September 5, 2024 08:13
@SuZhou-Joe
Copy link
Member

Run cypress tests (osd:ciGroup6) should be irrelevant to the code changes.

@SuZhou-Joe SuZhou-Joe merged commit d88e3b0 into 2.x Sep 5, 2024
63 of 65 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
@github-actions @opensearch-changeset-bot
@Kapian1234 @wanglam @ruanyl
[Workspace] Enable direct query connections to support in workspace (#…
85b0178 
…7839) (#8010)

* add dqc

* add dircet query connections on the detail page

* Changeset file for PR #7839 created/updated

* delete useless code

* optimize the code

* optimize the code

* Refactor association modal

* Integrate modal with workspace detail page

* Fix parent data source unchecked

* Remove all tab and sort connections by name alphabetical

* optimzie

* Fix checked status disappear after modal tab change

* optimize the dqc table

* optimize the code

* update the table css

* Simplify options update logic

* Add unit tests for AssociationDataSourceModal

* add unit test

* optimize the code

* Add nested support in associate data source modal

* delete useless code

* Change back type

* Update type in modal UT

* optimize the code

---------

(cherry picked from commit 0798865)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kapian1234 <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
(cherry picked from commit d88e3b0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 6, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Sep 6, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @Kapian1234 @wanglam @ruanyl
[Workspace] Enable direct query connections to support in workspace (#…
d7f422a 
…7839) (#8010) (#8048)

* add dqc

* add dircet query connections on the detail page

* Changeset file for PR #7839 created/updated

* delete useless code

* optimize the code

* optimize the code

* Refactor association modal

* Integrate modal with workspace detail page

* Fix parent data source unchecked

* Remove all tab and sort connections by name alphabetical

* optimzie

* Fix checked status disappear after modal tab change

* optimize the dqc table

* optimize the code

* update the table css

* Simplify options update logic

* Add unit tests for AssociationDataSourceModal

* add unit test

* optimize the code

* Add nested support in associate data source modal

* delete useless code

* Change back type

* Update type in modal UT

* optimize the code

---------

(cherry picked from commit 0798865)










(cherry picked from commit d88e3b0)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kapian1234 <[email protected]>
Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
all-star-contributor autocut Skip the changelog verification check on backports backport 2.17 failed changeset v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuZhou-Joe @ruanyl