[Backport 2.17] [Backport 2.x] [Workspace] Enable direct query connections to support in workspace #8048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…7839) (#8010) * add dqc * add dircet query connections on the detail page * Changeset file for PR #7839 created/updated * delete useless code * optimize the code * optimize the code * Refactor association modal * Integrate modal with workspace detail page * Fix parent data source unchecked * Remove all tab and sort connections by name alphabetical * optimzie * Fix checked status disappear after modal tab change * optimize the dqc table * optimize the code * update the table css * Simplify options update logic * Add unit tests for AssociationDataSourceModal * add unit test * optimize the code * Add nested support in associate data source modal * delete useless code * Change back type * Update type in modal UT * optimize the code --------- (cherry picked from commit 0798865) Signed-off-by: yubonluo <[email protected]> Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kapian1234 <[email protected]> Co-authored-by: Lin Wang <[email protected]> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit d88e3b0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.17 #8048 +/- ##
==========================================
+ Coverage 60.56% 60.60% +0.03%
==========================================
Files 3726 3727 +1
Lines 88171 88275 +104
Branches 13630 13657 +27
==========================================
+ Hits 53400 53497 +97
- Misses 31524 31527 +3
- Partials 3247 3251 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Sep 6, 2024
ruanyl
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d88e3b0 from #8010.