Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport][2.x][Workspace]Enable direct query connections to support in workspace #7983

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Sep 4, 2024

Description

[Manual Backport][2.x][Workspace]Enable direct query connections to support in workspace
#7839

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 87.57396% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.16%. Comparing base (f7a168d) to head (45dd1f3).
Report is 8 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ents/workspace_detail/select_data_source_panel.tsx 80.64% 2 Missing and 4 partials ⚠️
src/plugins/workspace/public/utils.ts 73.91% 6 Missing ⚠️
...workspace_detail/association_data_source_modal.tsx 90.00% 3 Missing and 2 partials ⚠️
.../workspace_detail/data_source_connection_table.tsx 96.49% 1 Missing and 1 partial ⚠️
...ts/workspace_form/direct_query_connection_icon.tsx 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7983      +/-   ##
==========================================
+ Coverage   61.13%   61.16%   +0.02%     
==========================================
  Files        3686     3687       +1     
  Lines       87139    87244     +105     
  Branches    13387    13414      +27     
==========================================
+ Hits        53275    53362      +87     
- Misses      30632    30645      +13     
- Partials     3232     3237       +5     
Flag Coverage Δ
Linux_1 28.90% <87.57%> (+0.10%) ⬆️
Linux_2 56.36% <ø> (ø)
Linux_4 29.69% <ø> (+0.01%) ⬆️
Windows_1 28.92% <87.57%> (+0.10%) ⬆️
Windows_2 56.31% <ø> (ø)
Windows_3 37.98% <ø> (ø)
Windows_4 29.69% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe
Copy link
Member

Close because of #8010

@SuZhou-Joe SuZhou-Joe closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants