Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new 'density' term #294

Merged
merged 9 commits into from
Dec 7, 2023
Merged

Added new 'density' term #294

merged 9 commits into from
Dec 7, 2023

Conversation

ar-ibrahim
Copy link
Collaborator

@ar-ibrahim ar-ibrahim requested a review from rays22 October 5, 2023 14:57
@ar-ibrahim ar-ibrahim self-assigned this Oct 5, 2023
@ar-ibrahim
Copy link
Collaborator Author

  • The paper defines breast density as the amount of fibroglandular versus fatty tissue in the breast, so I wonder if using the PATO quality mass density accurately reflects that. Existing OBA terms like nucleosome density, use the PATO quality amount. Is this a comparable case?

@ar-ibrahim ar-ibrahim marked this pull request as ready for review October 5, 2023 15:42
@rays22
Copy link
Contributor

rays22 commented Oct 20, 2023

They are looking at the composition of breast tissue in a population. One of the major tissue components is adipose tissue. They call this trait 'breast density', because they are looking at pixel densities of mammographs in 2D. I think the PATO quality composition --> fatty PATO:0002114 captures the gist of the genetic trait they are measuring.

  • Entity: UBERON:0000310 breast
  • Attribute: PATO:0002114 fatty

I would suggest to add a synonym like breast tissue density so that it is easier to find based on the original breast density term used in the paper.

@ar-ibrahim ar-ibrahim marked this pull request as draft December 7, 2023 10:24
@ar-ibrahim ar-ibrahim marked this pull request as ready for review December 7, 2023 10:44
Copy link
Contributor

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure that only the

OBA:2050351	breast density	UBERON:0000310	breast	PATO:0001019	mass density	breast tissue density	PMID:37345113	https://orcid.org/0000-0001-6757-4744

line is added to src/patterns/data/default/entity_attribute.tsv and nothing else is taken away or added.

@@ -1240,7 +1240,7 @@ OBA:0002278 GO:0030097 hemopoiesis PATO:0002181 displaced
OBA:0002279 UBERON:0008341 columella nasi PATO:0000122 length
OBA:0002280 UBERON:0001456 face PATO:0000052 shape
OBA:0002281 UBERON:0008200 forehead PATO:0000140 position
OBA:0002282 wateriness of faeces UBERON:0001988 feces PATO:0001548 quality of a liquid faeces liquidness|wateriness of feces https://orcid.org/0000-0001-8314-2140
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you are editing an earlier version of this file. Here you are undoing some edits that are unrelated to your addition of the density term.

@ar-ibrahim ar-ibrahim marked this pull request as draft December 7, 2023 11:04
@rays22
Copy link
Contributor

rays22 commented Dec 7, 2023

Suggested fix

Typically, a simple way to fix this and similar errors is as follows:

  1. Save the information (in this case 1 line from the src/patterns/data/default/entity_attribute.tsv file) that you want to add in a place outside of your github controlled PR branch (e.g. in a temporary textfile or a spreadsheet on your machine). You will want to add this back later:
OBA:2050351	breast density	UBERON:0000310	breast	PATO:0001019	mass density	breast tissue density	PMID:37345113	https://orcid.org/0000-0001-6757-4744
  1. Replace src/patterns/data/default/entity_attribute.tsv in your branch with the latest version of this file from the master branch. You can do that in many different ways. Here is how to do it on the command line:
git checkout master -- path/to/your/folder/entity_attribute.tsv
  1. Add back the line that you have removed in step 1 to the entity_attribute.tsv table.
  2. Update definitions.owl:
sh run.sh make ../patterns/definitions.owl
  1. Check in the 2 updated files (entity_attribute.tsv, definitions.owl) and commit to github.
  2. Push your changes from your local machine to github.
  3. Check if the only difference in entity_attribute.tsv between your branch and the master branch is the one line that you wanted to add.
    Let the QC and automatic actions complete and the PR is ready for review/merge.

@ar-ibrahim ar-ibrahim marked this pull request as ready for review December 7, 2023 13:29
Copy link
Contributor

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, including the new term from your previous PR (305) in definitions.owl .

@ar-ibrahim ar-ibrahim merged commit 444fb92 into master Dec 7, 2023
@ar-ibrahim ar-ibrahim deleted the add_NTR_density branch December 7, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants