-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new 'density' term #294
Conversation
ar-ibrahim
commented
Oct 5, 2023
- NTR: breast density New term request for Verma PMID: 37345113 EBISPOT/efo#2107
|
They are looking at the composition of breast tissue in a population. One of the major tissue components is adipose tissue. They call this trait 'breast density', because they are looking at pixel densities of mammographs in 2D. I think the PATO quality composition --> fatty PATO:0002114 captures the gist of the genetic trait they are measuring.
I would suggest to add a synonym like |
Co-authored-by: Ray Stefancsik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make sure that only the
OBA:2050351 breast density UBERON:0000310 breast PATO:0001019 mass density breast tissue density PMID:37345113 https://orcid.org/0000-0001-6757-4744
line is added to src/patterns/data/default/entity_attribute.tsv
and nothing else is taken away or added.
@@ -1240,7 +1240,7 @@ OBA:0002278 GO:0030097 hemopoiesis PATO:0002181 displaced | |||
OBA:0002279 UBERON:0008341 columella nasi PATO:0000122 length | |||
OBA:0002280 UBERON:0001456 face PATO:0000052 shape | |||
OBA:0002281 UBERON:0008200 forehead PATO:0000140 position | |||
OBA:0002282 wateriness of faeces UBERON:0001988 feces PATO:0001548 quality of a liquid faeces liquidness|wateriness of feces https://orcid.org/0000-0001-8314-2140 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you are editing an earlier version of this file. Here you are undoing some edits that are unrelated to your addition of the density term.
Suggested fixTypically, a simple way to fix this and similar errors is as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, including the new term from your previous PR (305) in definitions.owl .