Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W5][T09-3] Yow Ren Jie #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[W5][T09-3] Yow Ren Jie #46

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de27bc6
added goodbye command (without test)
arhjaye Feb 9, 2019
af2b629
edited test files
arhjaye Feb 9, 2019
4915916
updated user guide
arhjaye Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/seedu/addressbook/commands/HelpCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ public CommandResult execute() {
+ "\n" + ViewCommand.MESSAGE_USAGE
+ "\n" + ViewAllCommand.MESSAGE_USAGE
+ "\n" + HelpCommand.MESSAGE_USAGE
+ "\n" + ExitCommand.MESSAGE_USAGE
+ "\n" + GoodbyeCommand.MESSAGE_USAGE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary indentation. Reduces code readability.

+ "\n" + ExitCommand.MESSAGE_USAGE
);
}
}
2 changes: 2 additions & 0 deletions test/expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
|| Example: viewall 1
|| help: Shows program usage instructions.
|| Example: help
|| goodbye: prints goodbye message.
|| Example: goodbye
|| exit: Exits the program.
|| Example: exit
|| ===================================================
Expand Down
2 changes: 1 addition & 1 deletion test/java/seedu/addressbook/commands/AddCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class AddCommandTest {
private static final List<ReadOnlyPerson> EMPTY_PERSON_LIST = Collections.emptyList();
private static final Set<String> EMPTY_STRING_SET = Collections.emptySet();

@Test
@org.junit.jupiter.api.Test
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change do?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gautamrajulu how do you declare that a method is a test method?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ren jie why do you need a new junit framework for this enhancement?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arhjaye why do you need another junit test framework for your enhancement?

public void addCommand_invalidName_throwsException() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing header comment. All non-trivial methods should have java doc format header comments.

final String[] invalidNames = { "", " ", "[]\\[;]" };
for (String name : invalidNames) {
Expand Down
7 changes: 7 additions & 0 deletions test/java/seedu/addressbook/parser/ParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import org.junit.Before;
import org.junit.Test;

import seedu.addressbook.commands.GoodbyeCommand;
import seedu.addressbook.commands.AddCommand;
import seedu.addressbook.commands.ClearCommand;
import seedu.addressbook.commands.Command;
Expand Down Expand Up @@ -63,6 +64,12 @@ public void parse_unknownCommandWord_returnsHelp() {
* Tests for 0-argument commands =======================================================================
*/

@Test
public void parse_goodbyeCommand_parsedCorrectly() {
final String input = "goodbye";
parseAndAssertCommandType(input, GoodbyeCommand.class);
}

@Test
public void parse_helpCommand_parsedCorrectly() {
final String input = "help";
Expand Down