[W5][T09-3] Yow Ren Jie #46

arhjaye · 2019-02-11T08:04:31Z

No description provided.

gautamrajulu · 2019-02-11T12:12:01Z

test/java/seedu/addressbook/commands/AddCommandTest.java

@@ -28,7 +28,7 @@
    private static final List<ReadOnlyPerson> EMPTY_PERSON_LIST = Collections.emptyList();
    private static final Set<String> EMPTY_STRING_SET = Collections.emptySet();

-    @Test
+    @org.junit.jupiter.api.Test


What does this change do?

@gautamrajulu how do you declare that a method is a test method?

@ren jie why do you need a new junit framework for this enhancement?

@arhjaye why do you need another junit test framework for your enhancement?

stephlewyh

Hi Ren Jie, good job in doing the following:
(1) Updated user doc
(2) Updated tests

However, do remember to add header comments when you add new enhancements.

You may close this PR now.

stephlewyh · 2019-02-17T15:19:20Z

src/seedu/addressbook/commands/GoodbyeCommand.java

+    public static final String MESSAGE_USAGE = COMMAND_WORD + ": prints goodbye message.\n"
+            + "Example: " + COMMAND_WORD;
+
+    @Override


Missing header comment. All non-trivial methods (in this case your enhancement functionality) should have java doc format header comments.

stephlewyh · 2019-02-17T15:20:44Z

src/seedu/addressbook/parser/Parser.java

-import seedu.addressbook.commands.ListCommand;
-import seedu.addressbook.commands.ViewAllCommand;
-import seedu.addressbook.commands.ViewCommand;
+import seedu.addressbook.commands.*;


Imported classes should always be listed explicitly. E.g. java.util.List and not java.util.*, which does not follow NUS Java coding standards.

stephlewyh · 2019-02-17T15:21:34Z

src/seedu/addressbook/parser/Parser.java

@@ -73,6 +63,9 @@ public Command parseCommand(String userInput) {

        switch (commandWord) {

+            case GoodbyeCommand.COMMAND_WORD:


Unnecessary indentation here.

stephlewyh · 2019-02-17T15:22:31Z

src/seedu/addressbook/commands/HelpCommand.java

@@ -22,7 +22,8 @@ public CommandResult execute() {
                + "\n" + ViewCommand.MESSAGE_USAGE
                + "\n" + ViewAllCommand.MESSAGE_USAGE
                + "\n" + HelpCommand.MESSAGE_USAGE
-                + "\n" + ExitCommand.MESSAGE_USAGE
+                        + "\n" + GoodbyeCommand.MESSAGE_USAGE


Unnecessary indentation. Reduces code readability.

stephlewyh · 2019-02-17T15:23:37Z

test/java/seedu/addressbook/commands/AddCommandTest.java

@@ -28,7 +28,7 @@
    private static final List<ReadOnlyPerson> EMPTY_PERSON_LIST = Collections.emptyList();
    private static final Set<String> EMPTY_STRING_SET = Collections.emptySet();

-    @Test
+    @org.junit.jupiter.api.Test


@gautamrajulu how do you declare that a method is a test method?

stephlewyh · 2019-02-17T15:24:02Z

test/java/seedu/addressbook/commands/AddCommandTest.java

@@ -28,7 +28,7 @@
    private static final List<ReadOnlyPerson> EMPTY_PERSON_LIST = Collections.emptyList();
    private static final Set<String> EMPTY_STRING_SET = Collections.emptySet();

-    @Test
+    @org.junit.jupiter.api.Test
    public void addCommand_invalidName_throwsException() {


Missing header comment. All non-trivial methods should have java doc format header comments.

stephlewyh · 2019-02-17T15:25:44Z

test/java/seedu/addressbook/commands/AddCommandTest.java

@@ -28,7 +28,7 @@
    private static final List<ReadOnlyPerson> EMPTY_PERSON_LIST = Collections.emptyList();
    private static final Set<String> EMPTY_STRING_SET = Collections.emptySet();

-    @Test
+    @org.junit.jupiter.api.Test


@ren jie why do you need a new junit framework for this enhancement?

stephlewyh · 2019-02-17T15:26:33Z

test/java/seedu/addressbook/commands/AddCommandTest.java

@@ -28,7 +28,7 @@
    private static final List<ReadOnlyPerson> EMPTY_PERSON_LIST = Collections.emptyList();
    private static final Set<String> EMPTY_STRING_SET = Collections.emptySet();

-    @Test
+    @org.junit.jupiter.api.Test


@arhjaye why do you need another junit test framework for your enhancement?

arhjaye added 3 commits February 9, 2019 22:54

added goodbye command (without test)

de27bc6

edited test files

af2b629

updated user guide

4915916

nus-se-pr-bot added the tutorial.T09 label Feb 11, 2019

nus-se-pr-bot assigned stephlewyh Feb 11, 2019

nus-se-pr-bot added the team.3 label Feb 11, 2019

nus-se-pr-bot requested a review from okkhoy February 11, 2019 08:08

gautamrajulu reviewed Feb 11, 2019

View reviewed changes

stephlewyh reviewed Feb 17, 2019

View reviewed changes

stephlewyh added the Reviewed label Feb 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[W5][T09-3] Yow Ren Jie #46

[W5][T09-3] Yow Ren Jie #46

arhjaye commented Feb 11, 2019

gautamrajulu Feb 11, 2019

stephlewyh Feb 17, 2019

stephlewyh Feb 17, 2019

stephlewyh Feb 17, 2019

stephlewyh left a comment •

edited

Loading

stephlewyh Feb 17, 2019

stephlewyh Feb 17, 2019

stephlewyh Feb 17, 2019

stephlewyh Feb 17, 2019

stephlewyh Feb 17, 2019

stephlewyh Feb 17, 2019

stephlewyh Feb 17, 2019

stephlewyh Feb 17, 2019

		@@ -73,6 +63,9 @@ public Command parseCommand(String userInput) {

		switch (commandWord) {

		case GoodbyeCommand.COMMAND_WORD:

[W5][T09-3] Yow Ren Jie #46

Are you sure you want to change the base?

[W5][T09-3] Yow Ren Jie #46

Conversation

arhjaye commented Feb 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephlewyh left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephlewyh left a comment •

edited

Loading