-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W5][T09-3] Yow Ren Jie #46
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package seedu.addressbook.commands; | ||
|
||
|
||
/** | ||
* print goodbye message. | ||
*/ | ||
public class GoodbyeCommand extends Command { | ||
|
||
public static final String COMMAND_WORD = "goodbye"; | ||
|
||
public static final String MESSAGE_USAGE = COMMAND_WORD + ": prints goodbye message.\n" | ||
+ "Example: " + COMMAND_WORD; | ||
|
||
@Override | ||
public CommandResult execute() { | ||
return new CommandResult( | ||
"Goodbye World" | ||
); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,8 @@ public CommandResult execute() { | |
+ "\n" + ViewCommand.MESSAGE_USAGE | ||
+ "\n" + ViewAllCommand.MESSAGE_USAGE | ||
+ "\n" + HelpCommand.MESSAGE_USAGE | ||
+ "\n" + ExitCommand.MESSAGE_USAGE | ||
+ "\n" + GoodbyeCommand.MESSAGE_USAGE | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary indentation. Reduces code readability. |
||
+ "\n" + ExitCommand.MESSAGE_USAGE | ||
); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,17 +11,7 @@ | |
import java.util.regex.Matcher; | ||
import java.util.regex.Pattern; | ||
|
||
import seedu.addressbook.commands.AddCommand; | ||
import seedu.addressbook.commands.ClearCommand; | ||
import seedu.addressbook.commands.Command; | ||
import seedu.addressbook.commands.DeleteCommand; | ||
import seedu.addressbook.commands.ExitCommand; | ||
import seedu.addressbook.commands.FindCommand; | ||
import seedu.addressbook.commands.HelpCommand; | ||
import seedu.addressbook.commands.IncorrectCommand; | ||
import seedu.addressbook.commands.ListCommand; | ||
import seedu.addressbook.commands.ViewAllCommand; | ||
import seedu.addressbook.commands.ViewCommand; | ||
import seedu.addressbook.commands.*; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Imported classes should always be listed explicitly. E.g. |
||
import seedu.addressbook.data.exception.IllegalValueException; | ||
|
||
/** | ||
|
@@ -73,6 +63,9 @@ public Command parseCommand(String userInput) { | |
|
||
switch (commandWord) { | ||
|
||
case GoodbyeCommand.COMMAND_WORD: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary indentation here. |
||
return new GoodbyeCommand(); | ||
|
||
case AddCommand.COMMAND_WORD: | ||
return prepareAdd(arguments); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,7 @@ public class AddCommandTest { | |
private static final List<ReadOnlyPerson> EMPTY_PERSON_LIST = Collections.emptyList(); | ||
private static final Set<String> EMPTY_STRING_SET = Collections.emptySet(); | ||
|
||
@Test | ||
@org.junit.jupiter.api.Test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this change do? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gautamrajulu how do you declare that a method is a test method? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ren jie why do you need a new junit framework for this enhancement? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @arhjaye why do you need another junit test framework for your enhancement? |
||
public void addCommand_invalidName_throwsException() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing header comment. All non-trivial methods should have java doc format header comments. |
||
final String[] invalidNames = { "", " ", "[]\\[;]" }; | ||
for (String name : invalidNames) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing header comment. All non-trivial methods (in this case your enhancement functionality) should have java doc format header comments.