Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glycosylation annotation to B/Yam results #99

Closed
wants to merge 3 commits into from

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Nov 6, 2023

Description of proposed changes

Adds the same amino acid motifs entry from the three other seasonal flu lineages to B/Yam, so users can see changes in glycosylation sites in Nextclade results. The motif for B/Yam is the same as the motif for other lineages. These annotations most likely did not get included in the original addition of glycosylation sites because we suspected Yam was already extinct. These annotations should be helpful for researchers performing retrospective analyses, though.

Checklist

  • Checks pass

Adds the same amino acid motifs entry from the three other seasonal flu
lineages to B/Yam, so users can see changes in glycosylation sites in
Nextclade results. The motif for B/Yam is the same as the motif for
other lineages [1]. These annotations most likely did not get included
in the original addition of glycosylation sites [2] because we suspected
Yam was already extinct. These annotations should be helpful for
researchers performing retrospective analyses, though.

[1] https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6328934/#sec3title
[2] #64
@huddlej huddlej deployed to refs/pull/99/merge November 6, 2023 23:55 — with GitHub Actions Active
@ivan-aksamentov
Copy link
Member

Thanks, John! @huddlej

Technically seems to be working well:
https://master.clades.nextstrain.org/?dataset-server=gh:nextstrain/nextclade_data@add-yam-glyc-annotation@/data_output&dataset-name=nextstrain/flu/yam/ha/JN993010&input-fasta=example

But I cannot check the accuracy of science. Feel free to merge or check with Richard first, depending on how confident you are in the results :)

@huddlej
Copy link
Contributor Author

huddlej commented Nov 7, 2023

Thanks for the test link, @ivan-aksamentov! I'm 99.99% confident about the science, but I can wait for a 👍🏻 from @rneher just to be safe.

@rneher
Copy link
Member

rneher commented Dec 7, 2023

this got integrated in the new workflow. Thanks @huddlej !

@rneher rneher closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants