-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts for NCBI Virus #16
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9e32477
Copy ncbi-virus-url from monkeypox
joverlee521 ff44483
ncbi-virus-url: Remove references to mpox
joverlee521 2e91981
ncbi-virus-url: update help message for `--ncbi-taxon-id`
joverlee521 d98fcb7
ncbi-virus-url: Add `--filters` option
joverlee521 f952648
ncbi-virus-url: Add `--fields` option
joverlee521 a20c086
Add example of all fields for NCBI Virus
joverlee521 0065a38
Copy csv-to-ndjson from ncov-ingest
joverlee521 39a3364
Copy fetch-from-ncbi-virus from monkeypox
joverlee521 9d0e4e4
fetch-from-ncbi-virus: use ncbi-virus-url
joverlee521 a44f954
fetch-from-ncbi-virus: Add usage docs
joverlee521 ec2a692
csv-to-ndjson: Add usage docs
joverlee521 c5ad366
ncbi-virus-url: Add `updated` as an output column
joverlee521 aee5613
fetch-from-ncbi-virus: Add github_repo argument
joverlee521 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our latest meeting with WA DOH, people were concerned whether the clean data that Nextstrain hosts at data.nextstrain.org/files might exclude certain records from NCBI.
Allowing customizable filters here might add to that concern, but there's already so many other points in ingest pipelines that might filter out records. I think we just need to be better about documenting these filters that are used to generate the clean data.