Update export v2 Cram tests #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These Cram tests were written with old practices¹. Moving files around to adjust for newer practices. ¹ 5d2e370
The dev docs recommends against using TMP as a temporary directory¹. This also means data files must be referenced relative to TESTDIR. ¹ 5d2e370
Per recommendation in the dev docs¹. ¹ 5d2e370
With the previous changes, there's no longer a need to ensure output file names do not overlap.
3 tasks
|
This is a trivial change, so I plan to merge alongside #1261. |
Previously, the metadata ID column was assumed to be "strain" in some parts of the code. With changes such as 42f6cb2, this hardcoding should be removed so things can work properly with other ID columns. Co-authored-by: Jover <[email protected]>
… the metadata ID column
|
Oops, I merged #1261 before this PR. Closing since these commits have been merged over there. |
|
Double oops, I thought #1261 was merged into |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Apply recommendations from dev docs to existing Cram tests.
Related issue(s)
Related to #1176
Testing
Checklist
Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.N/A, no functional changes