Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update existing cram tests with new practices #1176

Open
7 of 16 tasks
victorlin opened this issue Mar 9, 2023 · 0 comments
Open
7 of 16 tasks

Update existing cram tests with new practices #1176

victorlin opened this issue Mar 9, 2023 · 0 comments

Comments

@victorlin
Copy link
Member

victorlin commented Mar 9, 2023 •
edited
Loading

Apply current recommendations to all tests:

  1. Keep cram files modular. This makes it easier to see which command is failing.
  2. Create files in the initial working directory, as it is a temporary working directory unique to the test. Note that the name of the $TMP directory is misleading - although it is temporary, it is shared across all tests so you'll have to explicitly remove files at the end of each test to avoid affecting other tests. The initial directory of each test is a unique directory within $TMP.

Everything works fine, but it would be nice to update across the board so new changes won't continue to follow old patterns.

Checklist
@victorlin victorlin mentioned this issue Mar 16, 2023
Merged
2 tasks
@victorlin victorlin mentioned this issue Mar 31, 2023
Merged
2 tasks
@victorlin victorlin mentioned this issue Jul 24, 2023
Merged
2 tasks
@victorlin victorlin mentioned this issue Dec 7, 2023
Merged
jameshadfield added a commit that referenced this issue Dec 11, 2023
@jameshadfield
[translate] update test syntax / format
63929ee 
The move to "Creating files in the initial working directory" is
motivated by
<#1344 (comment)>
and <#1176>.

Additionally, I remove the pushd commands which were confusing (there
were multiple!) and use variables to refer to common directories to
improve readability.
@jameshadfield jameshadfield mentioned this issue Dec 11, 2023
Merged
2 tasks
jameshadfield added a commit that referenced this issue Dec 19, 2023
@jameshadfield
[translate] update test syntax / format
0987264 
The move to "Creating files in the initial working directory" is
motivated by
<#1344 (comment)>
and <#1176>.

Additionally, I remove the pushd commands which were confusing (there
were multiple!) and use variables to refer to common directories to
improve readability.
@victorlin victorlin mentioned this issue May 14, 2024
Closed
@victorlin victorlin mentioned this issue Jul 26, 2024
Closed
@victorlin victorlin mentioned this issue Sep 26, 2024
Merged
5 tasks
@victorlin victorlin mentioned this issue Oct 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Nextstrain planning (archived)
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@victorlin