Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine: Update Cram tests #1184

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Mar 16, 2023

Description of proposed changes

Applying new practices to old tests.

Related issue(s)

Related to #1176

Testing

  • Tests still pass

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file. N/A, no functional changes

See 3c81130 for reasoning.

Additional --exclude-paths are necessary when calling diff_jsons.py to
avoid failing on the new differences in input filepaths.
@victorlin victorlin self-assigned this Mar 16, 2023
@victorlin victorlin marked this pull request as ready for review March 16, 2023 21:17
@victorlin
Copy link
Member Author

Merging so #1142 can be merged directly onto master.

@victorlin victorlin merged commit ca0f042 into master Mar 29, 2023
@victorlin victorlin deleted the victorlin/update-refine-cram-tests branch March 29, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant