Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPDX header - batch #1 #45244

Merged
merged 4 commits into from
May 10, 2024
Merged

Add SPDX header - batch #1 #45244

merged 4 commits into from
May 10, 2024

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented May 9, 2024

  • Resolves: noid

Summary

  • first batch of files with SPDX headers added
  • ensured all names are wihtin the authors' file
  • renamed some files to markdown (authors and copying-readme) for better formatting
  • added a dep5 file with definitions for all translations.

This PR brings us to

  • files with copyright information: 8295 / 10990
  • files with license information: 4243 / 10990

TODO

  • review
  • create further PRs after each SPDX PR got merged, to get to 100% in batches - in the end for every file in the repo there will be a copyright and license info present.

Checklist

@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone May 9, 2024
@AndyScherzinger AndyScherzinger changed the title Add SPDX header Add SPDX header - Batch #1 May 9, 2024
@AndyScherzinger AndyScherzinger changed the title Add SPDX header - Batch #1 Add SPDX header - batch #1 May 9, 2024
@AndyScherzinger
Copy link
Member Author

also looping in @skjnldsv @Altahrim @blizzz for af73ed0 - just in case more is needed from a release/packaging perspective

@AndyScherzinger
Copy link
Member Author

/compile

build/psalm-baseline.xml Outdated Show resolved Hide resolved
build/psalm-baseline-ocp.xml Outdated Show resolved Hide resolved
build/psalm/AppFrameworkTainter.php Outdated Show resolved Hide resolved
build/stubs/IntlChar.php Outdated Show resolved Hide resolved
core/css/animations.scss Outdated Show resolved Hide resolved
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx branch 2 times, most recently from a0dbcca to e963d94 Compare May 10, 2024 08:33
@AndyScherzinger
Copy link
Member Author

Resolved all your comments @nickvergessen 👍 Thanks!

@nickvergessen
Copy link
Member

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@blizzz
Copy link
Member

blizzz commented May 10, 2024

also looping in @skjnldsv @Altahrim @blizzz for af73ed0 - just in case more is needed from a release/packaging perspective

https://github.com/nextcloud/updater/blob/master/lib/Updater.php#L206-L257

Keep in mind the the next upgrade will always work with the already shipped updater!

@blizzz
Copy link
Member

blizzz commented May 10, 2024

@AndyScherzinger during release building, we delete COPYING-README from bundled apps. Should this stay?

@AndyScherzinger AndyScherzinger merged commit e38ddf8 into master May 10, 2024
159 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/spdx branch May 10, 2024 10:14
@AndyScherzinger
Copy link
Member Author

@blizzz

@AndyScherzinger during release building, we delete COPYING-README from bundled apps. Should this stay?

No, can still be removed.

https://github.com/nextcloud/updater/blob/master/lib/Updater.php#L206-L257
Keep in mind the the next upgrade will always work with the already shipped updater!

I'll create a PR, will need a review since I can't say if expected files which are missing would be an issue.

@AndyScherzinger
Copy link
Member Author

I reverted the renaming of the root folder files, to keep the changeset for the updater small(er) #45250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants