-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPDX header - batch #2 #45252
Add SPDX header - batch #2 #45252
Conversation
fc1597a
to
0182c35
Compare
7f67678
to
3880707
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@susnux, can you please re-review. I triggered the compile and before that pushed all headers for |
Any hints as to why the changed/now SPDX header won't get copied over? see i.e. 95f1c09#diff-21c6a91f3d35ef70889606c918fa3ee8d5dbd41e0983ccba0514c49263065ba5 |
@AndyScherzinger yes because by default the regex to detect licenses does not include the spdx identifiers. |
accc95b
to
8a06a01
Compare
/compile |
ff75e63
to
b8aab62
Compare
5bee611
to
4335203
Compare
@AndyScherzinger despite of #45259 I pushed a commit that fixes extracting the comments (added |
@susnux sounds good, however the SPDX headers don't start with an |
8e72f8a
to
3296936
Compare
e5bb140
to
ee5d691
Compare
Yes, fixed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash?
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
ee5d691
to
cba9a7f
Compare
Commits combined so they still "make sense" and are specific to their actual character of change |
Summary
Add further SPDX header or reformat existing headers for the converter to work
Before
After
TODO
Checklist