Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse compliance / license identifier / SPDX #29723

Closed
CarlSchwan opened this issue Nov 15, 2021 · 5 comments
Closed

Reuse compliance / license identifier / SPDX #29723

CarlSchwan opened this issue Nov 15, 2021 · 5 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement low

Comments

@CarlSchwan
Copy link
Member

There is now a specification about how to declare license in for our source code: reuse.software

This would allow to replace:

<?php
/**
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 *
 * @author Christoph Wurst <[email protected]>
 * @author Joas Schilling <[email protected]>
 *
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program. If not, see <http://www.gnu.org/licenses/>
 *
 */

with

<?php
/**
 * SPDX-FileCopyrightText: 2016, ownCloud, Inc.
 * SPDX-FileCopyrightText: Christoph Wurst <[email protected]>
 * SPDX-FileCopyrightText: Joas Schilling <[email protected]>
 * SPDX-License-Identifier: AGPL-3.0-only
 */

This has the following advantages:

  • It's shorter :)
  • It's machine-readable, so we can have a CI job verify that no file is missing licensing statements
  • It's standardized using SPDX identifiers and is starting to get adopted in many other large open-source projects: e.g. Linux kernel, KDE

For porting to SPDX, I had a good experience using licensedigger. It supports a wide range of licenses and is easy to add more in our case AGPL-3.0-or-later and AGPL-3.0-only. If people are okay I could do that in some small apps first so that we can look at the result before doing the server repo.

@CarlSchwan CarlSchwan added enhancement 1. to develop Accepted and waiting to be taken care of low labels Nov 15, 2021
@CarlSchwan
Copy link
Member Author

I ported the profiler repo to use it nextcloud/profiler#14

@schiessle
Copy link
Member

It would be really great if we would become reuse compliant, thanks for bringing this up @CarlSchwan

Sometimes we also need to provide a overview over all Free Software licenses withing Nextcloud, this would also make it easier to compile such a list.

@mgallien
Copy link
Contributor

mgallien commented Aug 3, 2022

Switching to reuse compliant license/copyright notices would also allow to automatically check for compliance in our CI pipelines on pull requests
see https://reuse.software/dev/#ci

@CarlSchwan
Copy link
Member Author

I started porting groupfolders to reuse here: nextcloud/groupfolders#2046

This requires the following patch to teach licensedigger to correctly identify Nextcloud headers https://invent.kde.org/sdk/licensedigger/-/merge_requests/99

@joshtrichards joshtrichards changed the title Reuse compliance Reuse compliance / license identifier Sep 3, 2023
@joshtrichards joshtrichards changed the title Reuse compliance / license identifier Reuse compliance / license identifier / SPDX Sep 3, 2023
@juliusknorr
Copy link
Member

Has been done with #45244 and several follow up prs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement low
Projects
None yet
Development

No branches or pull requests

4 participants