-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(deleteAction): Queue delete requests #45237
Conversation
f53850e
to
c650f7d
Compare
c650f7d
to
35e9de0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly an improvement, but since this is all browser side aren't we creating a new problem: i.e. if the browser is closed before the entire delete session finishes?
Maybe we go farther and add the full item list to a new background job handled server-side? We already expire the trash contents in a background job so...
Perhaps more appropriate in a future follow-up (if the browser being closed aborting the delete queue is considered acceptable for now).
I do not know any WebDAV standard allowing bulk delete so this would need a custom API so definitely a thing we need to think through. |
35e9de0
to
36ec764
Compare
/compile |
What about adding a word on the already exitsting message like:
Could this be a thing? |
4181490
to
424989c
Compare
424989c
to
5e74c11
Compare
/compile |
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
Signed-off-by: fenn-cs <[email protected]>
When multiple files are deleted at once, all the requests bombard the server simultaneously, causing performance issues. This commit adds queuing that limits the concurrency of these requests to 5 at a time. Signed-off-by: fenn-cs <[email protected]>
d52b8a8
to
21a22a3
Compare
/compile |
Signed-off-by: nextcloud-command <[email protected]>
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/45237/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 23c71bd8 21a22a39 18f5507e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45237/stable27 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable27 |
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/45237/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 23c71bd8 21a22a39 18f5507e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45237/stable27 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
When multiple files are deleted at once, all the requests bombard the server simultaneously, causing performance issues.
This commit adds queuing that limits the concurrency of these requests to 5 at a time.
Without Queuing
With Queuing
Resolves : #45234