Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve queueing for deletion #45281

Open
nfebe opened this issue May 13, 2024 · 5 comments
Open

Improve queueing for deletion #45281

nfebe opened this issue May 13, 2024 · 5 comments
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: dav performance 🚀

Comments

@nfebe
Copy link
Contributor

nfebe commented May 13, 2024

Bug description

See : #45237 (review)

  • Update frontend to provide feedback about not closing browser/window when multiple delete.
  • Explore means to queue deletion in the backend jobs.
@nfebe nfebe added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels May 13, 2024
@nfebe nfebe self-assigned this May 13, 2024
@nfebe nfebe changed the title [Bug]: Improve queueing for deletion Improve queueing for deletion May 13, 2024
@nfebe nfebe added feature: dav performance 🚀 and removed bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels May 13, 2024
@skjnldsv
Copy link
Member

Preventing closing with onbeforeunload is the cleanest way imho

@AndyXheli
Copy link

AndyXheli commented May 17, 2024

I read a previous comment that once this operation starts a user needs to leave the windows open I think it would be more productive that once a users starts this operation they can leave the page and do other tasks and not wait for this job to complete. The job should be completed in the backend. Currently, that's how Google Drive, Onedrive, etc. You don't need to keep the windows open or two stay on the delete page. Once the delete operation starts, you can leave that page and do other stuff.

@skjnldsv
Copy link
Member

Yep, there is currently no asynchronous operations.
That is kind of a different topic

@AndyXheli
Copy link

Do you think that would be something that will get implemented?

@skjnldsv
Copy link
Member

@AndyXheli at some point I hope so, that would allow to only send one request for a batch of actions.
Then we would not even need to throttle them. But we're using webdav, so we would have to create our own plugin or implementation for this. I think there is an opened issue about this already :)

@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: dav performance 🚀
Projects
None yet
Development

No branches or pull requests

4 participants