Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] perf(deleteAction): Queue delete requests #45327

Merged
merged 1 commit into from
May 16, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 15, 2024

Backport of #45237

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, Pytal, susnux and nfebe May 15, 2024 12:10
@backportbot backportbot bot added this to the Nextcloud 28.0.6 milestone May 15, 2024
@artonge artonge marked this pull request as ready for review May 16, 2024 15:32
@artonge
Copy link
Contributor

artonge commented May 16, 2024

/compile /

@artonge
Copy link
Contributor

artonge commented May 16, 2024

/backport! to stable27

Copy link
Author

backportbot bot commented May 16, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/45327/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 90180b15

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45327/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

When multiple files are deleted at once, all the requests bombard the server
simultaneously, causing performance issues.

This commit adds queuing that limits the concurrency of these requests to 5
at a time.

Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2024
@artonge artonge merged commit 58711fb into stable28 May 16, 2024
45 checks passed
@artonge artonge deleted the backport/45237/stable28 branch May 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request feature: dav performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants