Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Clarify PR merging responsibility #124

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[ENH] Clarify PR merging responsibility #124

merged 2 commits into from
Nov 13, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Nov 13, 2023

Closes #108

See also neurobagel/.github#7

Checklist

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit 8ba986b
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/655286276f16b20008ddc79d
😎 Deploy Preview https://deploy-preview-124--neurobagel-documentation.netlify.app/contributing/pull_requests
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two 🍒 suggestions for clarity, otherwise 🧑‍🍳

docs/contributing/pull_requests.md Outdated Show resolved Hide resolved
docs/contributing/pull_requests.md Outdated Show resolved Hide resolved
@alyssadai alyssadai merged commit 8f4c5c2 into main Nov 13, 2023
5 checks passed
@alyssadai alyssadai deleted the pr-info branch November 13, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Describe merge responsibility in PR review section
2 participants