Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Clarify PR merging responsibility #124

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[ENH] Clarify PR merging responsibility #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b13949
clarify PR merge responsibility
alyssadai Nov 13, 2023
8ba986b
better differentiate PRs internal vs. external to developer team
alyssadai Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/contributing/pull_requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Instead, for documentation content changes, the following prefixes can be used t
- `[FIX]`: Fixing errors in the documentation

## Pull request reviews
A developer will review each PR and may provide comments or suggestions for the PR author to address.
A core maintainer will review each PR and may provide comments or suggestions for the PR author to address.

Neurobagel PR reviews may use the following emoji signifiers:

Expand All @@ -31,3 +31,8 @@ Neurobagel PR reviews may use the following emoji signifiers:
:cherries:: Some optional/suggested changes that could be nice to have but are not required to merge

If (required) changes are requested, the PR author should re-request a review from the reviewer once the comments have been addressed.

### When your pull request is approved
If you **are not a member of the Neurobagel developer team**: the reviewing Neurobagel maintainer is responsible for merging the PR.

If you **are a member of the Neurobagel developer team** (i.e., you have write access to the repository): the PR author is responsible for merging the PR.