Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten template comments and add link to docs on PR process #7

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Shorten template comments and add link to docs on PR process #7

merged 2 commits into from
Nov 13, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Nov 13, 2023 •
edited by surchs
Loading

Closes neurobagel/documentation#108

See also neurobagel/documentation#124

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai mentioned this pull request Nov 13, 2023
Merged
3 tasks
@surchs surchs self-requested a review November 13, 2023 19:45
surchs
surchs approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit 2408064 into main Nov 13, 2023
@alyssadai alyssadai deleted the adai/update-pr-template branch November 13, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Describe merge responsibility in PR review section
2 participants
@alyssadai @surchs