fix: stop re-exporting exports removed in [email protected] #459
+266
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-serverless ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for remix-edge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
These unstable functions and types were removed in remix-run/remix#9893. Since they were clearly named `unstable_` and Remix doesn't require major releases for changes to these, we'll do the same thing.
serhalp
force-pushed
the
serhalp/frb-1327-named-export-unstable_defineaction-not-found
branch
from
f40a954
to
ddfa2d8
Compare
mrstork
approved these changes
Sep 18, 2024
mrstork
reviewed
Sep 18, 2024
| unstable_setDevServerHooks, | ||
| UNSAFE_SingleFetchRedirectSymbol, | ||
| } from '@remix-run/server-runtime' | ||
|
|
||
| // TODO(serhalp) The docs say we should simply re-export all types from `/reexport`: | ||
| // https://github.com/remix-run/remix/tree/main/packages/remix-server-runtime#readme. | ||
| // Let's do that, but carefully verify whether this adds or removes any exports first. |
There was a problem hiding this comment.
Shall we make a linear ticket?
There was a problem hiding this comment.
Yes. Would you mind doing that? Or we could just open a draft PR that does that (and removes the remaining unstable_ exports) and we'll keep track of if that way.
serhalp
deleted the
serhalp/frb-1327-named-export-unstable_defineaction-not-found
branch
Merged
serhalp
added a commit
to netlify/hydrogen-template
that referenced
this pull request
Sep 18, 2024
To get this fix: netlify/remix-compute#459.
serhalp
added a commit
to netlify/hydrogen-template
that referenced
this pull request
Sep 18, 2024
To get this fix: netlify/remix-compute#459.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some "unstable" functions and types were removed in remix-run/remix#9893.
Since they were clearly named
unstable_and Remix doesn't require major releases for changes to these, we'll do the same thing here.We should probably just not export any
unstable_e xports. Remix doesn't actually require that server runtime implementations export these: https://github.com/remix-run/remix/tree/main/packages/remix-server-runtime#readme.Related Tickets & Documents
Closes #458, which actually affects both Remix and Hydrogen.
QA Instructions, Screenshots, Recordings
N/A - just bumps remix dev dep and fixes type errors