Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop re-exporting exports removed in [email protected] #459

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix: stop re-exporting exports removed in [email protected] #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddfa2d8
fix: stop re-exporting exports removed in remix 2.12.0
serhalp Sep 18, 2024
365fa5a
chore(deps): bump to latest remix everywhere
serhalp Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/remix-adapter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@
},
"homepage": "https://github.com/netlify/remix-compute#readme",
"dependencies": {
"@remix-run/node": "^2.9.2",
"@remix-run/node": "^2.12.0",
"isbot": "^5.0.0"
},
"devDependencies": {
"@netlify/functions": "^2.8.1",
"@remix-run/dev": "^2.9.2",
"@remix-run/react": "^2.9.2",
"@remix-run/dev": "^2.12.0",
"@remix-run/react": "^2.12.0",
"@types/react": "^18.0.27",
"@types/react-dom": "^18.0.10",
"lambda-tester": "^4.0.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/remix-edge-adapter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@
"homepage": "https://github.com/netlify/remix-compute#readme",
"dependencies": {
"@netlify/remix-runtime": "2.3.0",
"@remix-run/dev": "^2.9.2",
"@remix-run/dev": "^2.12.0",
"isbot": "^5.0.0"
},
"devDependencies": {
"@remix-run/react": "^2.9.2",
"@remix-run/react": "^2.12.0",
"@types/react": "^18.0.27",
"@types/react-dom": "^18.0.10",
"react": "^18.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/remix-runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"homepage": "https://github.com/netlify/remix-compute#readme",
"devDependencies": {
"@remix-run/server-runtime": "^2.9.2",
"@remix-run/server-runtime": "^2.12.0",
"tsup": "^8.0.2"
},
"peerDependencies": {
Expand Down
8 changes: 3 additions & 5 deletions packages/remix-runtime/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,13 @@ export {
unstable_composeUploadHandlers,
unstable_createMemoryUploadHandler,
unstable_parseMultipartFormData,
unstable_defineLoader,
unstable_defineAction,
unstable_setDevServerHooks,
UNSAFE_SingleFetchRedirectSymbol,
} from '@remix-run/server-runtime'

// TODO(serhalp) The docs say we should simply re-export all types from `/reexport`:
// https://github.com/remix-run/remix/tree/main/packages/remix-server-runtime#readme.
// Let's do that, but carefully verify whether this adds or removes any exports first.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make a linear ticket?

Copy link
Contributor Author

@serhalp serhalp Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Would you mind doing that? Or we could just open a draft PR that does that (and removes the remaining unstable_ exports) and we'll keep track of if that way.

export type {
ActionFunction,
ActionFunctionArgs,
Expand Down Expand Up @@ -78,9 +79,6 @@ export type {
UnsignFunction,
UploadHandlerPart,
UploadHandler,
unstable_Loader,
unstable_Action,
unstable_Serialize,
UNSAFE_SingleFetchResults,
UNSAFE_SingleFetchResult,
} from '@remix-run/server-runtime'
Loading