Skip to content

Commit

Permalink
fix: stop re-exporting exports removed in remix 2.12.0
Browse files Browse the repository at this point in the history
These unstable functions and types were removed in
remix-run/remix#9893.

Since they were clearly named `unstable_` and Remix doesn't require
major releases for changes to these, we'll do the same thing.
  • Loading branch information
serhalp committed Sep 18, 2024
1 parent a15ef14 commit ddfa2d8
Show file tree
Hide file tree
Showing 4 changed files with 237 additions and 15 deletions.
2 changes: 1 addition & 1 deletion packages/remix-edge-adapter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"isbot": "^5.0.0"
},
"devDependencies": {
"@remix-run/react": "^2.9.2",
"@remix-run/react": "^2.12.0",
"@types/react": "^18.0.27",
"@types/react-dom": "^18.0.10",
"react": "^18.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/remix-runtime/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"homepage": "https://github.com/netlify/remix-compute#readme",
"devDependencies": {
"@remix-run/server-runtime": "^2.9.2",
"@remix-run/server-runtime": "^2.12.0",
"tsup": "^8.0.2"
},
"peerDependencies": {
Expand Down
8 changes: 3 additions & 5 deletions packages/remix-runtime/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,13 @@ export {
unstable_composeUploadHandlers,
unstable_createMemoryUploadHandler,
unstable_parseMultipartFormData,
unstable_defineLoader,
unstable_defineAction,
unstable_setDevServerHooks,
UNSAFE_SingleFetchRedirectSymbol,
} from '@remix-run/server-runtime'

// TODO(serhalp) The docs say we should simply re-export all types from `/reexport`:
// https://github.com/remix-run/remix/tree/main/packages/remix-server-runtime#readme.
// Let's do that, but carefully verify whether this adds or removes any exports first.
export type {
ActionFunction,
ActionFunctionArgs,
Expand Down Expand Up @@ -78,9 +79,6 @@ export type {
UnsignFunction,
UploadHandlerPart,
UploadHandler,
unstable_Loader,
unstable_Action,
unstable_Serialize,
UNSAFE_SingleFetchResults,
UNSAFE_SingleFetchResult,
} from '@remix-run/server-runtime'
240 changes: 232 additions & 8 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ddfa2d8

Please sign in to comment.