Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
## [1.3.0-pre.4] - 2024-07-17

### Fixed

* Pink materials when causing a domain reload while a subscene is open with lightmapped materials.
  • Loading branch information
Unity Technologies committed Jul 17, 2024
1 parent 76d0642 commit 0a23225
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 12 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ uid: changelog

# Changelog

## [1.3.0-pre.4] - 2024-07-17

### Fixed

* Pink materials when causing a domain reload while a subscene is open with lightmapped materials.


## [1.3.0-exp.1] - 2024-06-11

### Changed
Expand Down
4 changes: 2 additions & 2 deletions Unity.Entities.Graphics/RenderMeshBakingContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public struct LightMapReference
private int m_NumLightMappedMaterialCacheMisses;

private Dictionary<LightMapKey, LightMapReference> m_LightMapArrayCache;
private Dictionary<MaterialLookupKey, UnityObjectRef<Material>> m_LightMappedMaterialCache = new ();
private Dictionary<MaterialLookupKey, Material> m_LightMappedMaterialCache = new ();

private List<int> m_UsedLightmapIndices = new List<int>();
private Dictionary<int, LightMapReference> m_LightMapReferences;
Expand Down Expand Up @@ -226,7 +226,7 @@ public UnityObjectRef<Material> GetLightMappedMaterial(UnityObjectRef<Material>
}
}

private static UnityObjectRef<Material> CreateLightMappedMaterial(UnityObjectRef<Material> material, LightMaps lightMaps)
private static Material CreateLightMappedMaterial(UnityObjectRef<Material> material, LightMaps lightMaps)
{
var lightMappedMaterial = new Material(material);
lightMappedMaterial.name = $"{lightMappedMaterial.name}_Lightmapped_";
Expand Down
10 changes: 5 additions & 5 deletions ValidationExceptions.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,29 @@
{
"ValidationTest": "API Updater Configuration Validation",
"ExceptionMessage": "stdout:\nAPIUpdater Configuration Validation\n-----------------------------------\n\nConfiguration Validation Tests (Failed: 0, Total: 1, Ignored 0):\n----------------------------------------------------------------\n\n\nAuto Generated Tests (Failed: 1, Total: 1, Ignored 0):\n------------------------------------------------------\n1) Expected updates not applied for configuration:\n[*] System.SByte [*] Unity.Rendering.MaterialMeshInfo::Submesh -> * Unity.Rendering.MaterialMeshInfo::SubMesh\n\nInput : unsafe class Test : object { System.SByte Method(System.SByte memberValue, Unity.Rendering.MaterialMeshInfo obj) { System.SByte local = obj.Submesh; return Method(obj.Submesh, obj); } }\nExpected: unsafe class Test : object { System.UInt16 Method(System.UInt16 memberValue, Unity.Rendering.MaterialMeshInfo obj) { System.UInt16 local = obj.SubMesh; return Method(obj.SubMesh, obj); } }\nActual : unsafe class Test : object { System.SByte Method(System.SByte memberValue, Unity.Rendering.MaterialMeshInfo obj) { System.SByte local = obj.SubMesh; return Method(obj.SubMesh, obj); } }\n\n\nBase type validation (Failed: 0, Total: 0, Ignored 0):\n------------------------------------------------------\nstderr:\n",
"PackageVersion": "1.3.0-exp.1"
"PackageVersion": "1.3.0-pre.4"
},
{
"ValidationTest": "API Validation",
"ExceptionMessage": "Breaking changes require a new major version.",
"PackageVersion": "1.3.0-exp.1"
"PackageVersion": "1.3.0-pre.4"
}
],
"WarningExceptions": [
{
"ValidationTest": "Manifest Validation",
"ExceptionMessage": "Package dependency [email protected] must be promoted to production before this package is promoted to production. (Except for core packages)",
"PackageVersion": "1.3.0-exp.1"
"PackageVersion": "1.3.0-pre.4"
},
{
"ValidationTest": "Folder Structure Validation",
"ExceptionMessage": "The Resources Directory should not be used in packages. For more guidance, please visit https://docs.unity3d.com/Manual/BestPracticeUnderstandingPerformanceInUnity6.html",
"PackageVersion": "1.3.0-exp.1"
"PackageVersion": "1.3.0-pre.4"
},
{
"ValidationTest": "Package Lifecycle Validation",
"ExceptionMessage": "com.unity.entities.graphics has never been promoted to production before. Please contact Release Management through slack in #devs-pkg-promotion to promote the first version of your package before trying to use this automated pipeline. Read more about this error and potential solutions at https://docs.unity3d.com/Packages/com.unity.package-validation-suite@latest/index.html?preview=1&subfolder=/manual/lifecycle_validation_error.html#the-very-first-version-of-a-package-must-be-promoted-by-release-management",
"PackageVersion": "1.3.0-exp.1"
"PackageVersion": "1.3.0-pre.4"
}
]
}
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"name": "com.unity.entities.graphics",
"displayName": "Entities Graphics",
"version": "1.3.0-exp.1",
"version": "1.3.0-pre.4",
"unity": "2022.3",
"unityRelease": "11f1",
"description": "The Entities Graphics package provides systems and components for drawing meshes using DOTS, including support for instanced mesh rendering and LOD.",
"dependencies": {
"com.unity.entities": "1.3.0-exp.1",
"com.unity.entities": "1.3.0-pre.4",
"com.unity.modules.particlesystem": "1.0.0",
"com.unity.render-pipelines.core": "14.0.9"
},
Expand All @@ -17,15 +17,15 @@
"unity"
],
"_upm": {
"changelog": "### Changed\n\n* Updated entities packages dependencies\n\n### Fixed\n\n* Fixed an issue with RegisterMaterialsAndMeshes"
"changelog": "### Fixed\n\n* Pink materials when causing a domain reload while a subscene is open with lightmapped materials."
},
"upmCi": {
"footprint": "a2108783823d233fc9497067bd942e9abf8d718d"
"footprint": "a5e32d10578d6b283b267f5fef1d7ef03714e0b1"
},
"documentationUrl": "https://docs.unity3d.com/Packages/[email protected]/manual/index.html",
"repository": {
"url": "https://github.cds.internal.unity3d.com/unity/dots.git",
"type": "git",
"revision": "d5bde5f043ad76defc80bbc6be1f8630d14b108d"
"revision": "6b0c8d27a0224c9cf76032c48d1b981e9750f10d"
}
}

0 comments on commit 0a23225

Please sign in to comment.