This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
[develop] Start of version 5 - WebExtension Experiments #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motin
force-pushed
the
v5-init
branch
2 times, most recently
from
bb72c7a to
b5be903
Compare
gregglind
approved these changes
Apr 2, 2018
… use a specific version from npm)
…make an xpi for the test-addon)
…m + readme updated to reflect this + files moved to their proper location
…ck require instead of ChromeUtils.import(context.extension.getURL(...))
…I from the extension page for tests
…t utils into separate files based on type of test util method
…ion of background script logic be initiated by messages
…me dependency since the experimental APIs are used at runtime
Merged
…+ restored some initial tests:
✓ should be able to access window.browser from the extension page for tests (1450ms)
✓ should be able to access study WebExtensions API from the extension page for tests (67ms)
✓ should return the correct variation based on specific weightedVariations (165ms)
gregglind
reviewed
Apr 3, 2018
| @@ -54,9 +54,11 @@ async function initiateStudy() { | |||
| studySetup.expired = await Study.hasExpired(); | |||
| // Ensure we have configured study and are supposed to run our feature | |||
| await browser.study.configure(studySetup); | |||
| // Get study variation | |||
| // Run the startup study checks | |||
| await browser.study.startup(); | |||
There was a problem hiding this comment.
what effects / side effects does this have?
gregglind
reviewed
Apr 3, 2018
| @@ -5,14 +5,18 @@ set -o errexit | |||
|
|
|||
There was a problem hiding this comment.
soon, let's make this into a node script.
|
@motin please hold off on more commits on this branch until we can actually read this and land it. |
Closed
biancadanforth
added a commit
to biancadanforth/shield-study-webextension-experiment-template
that referenced
this pull request
Apr 5, 2018
Based on prior work in the Shield Studies Addon Template repo (mozilla/shield-studies-addon-template#55) and Shield Studies Addon Utils repo (mozilla/shield-studies-addon-utils#120). This was just a proof-of-concept for me to understand the basics of creating experimental APIs for use in WebExtension Experiments (WEEs). This WEE simply sets the "browser.privatebrowsing.autostart" boolean preference to "true" via an experimental "prefchange" WebExtension API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress for the necessary changes to leave legacy extensions behind and ship study add-ons using bundled WebExtension experiments.
Used by the new WebExtension Experiments-based template / example study in https://github.com/mozilla/shield-studies-addon-template.
Includes the following PRs in the following order:
Thus, reviewing this PR will be less noisy after having accepted the above PRs against the develop branch.