This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
[v5] Npm run format #119
Merged
[v5] Npm run format #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.eslintrc.js
Outdated
| semi: ["error", "always"], | ||
| "require-jsdoc": "warn", | ||
| "valid-jsdoc": "warn", | ||
| "max-len": ["error", 80], |
There was a problem hiding this comment.
This rule is anyways removed in #120 since it follows the suggested config from mozilla/shield-studies-addon-template#61 as a base.
| @@ -58,30 +58,44 @@ module.exports.promiseSetupDriver = async() => { | |||
| .forBrowser("firefox") | |||
| .setFirefoxOptions(options); | |||
|
|
|||
| const binaryLocation = await promiseActualBinary(process.env.FIREFOX_BINARY || "firefox"); | |||
| const binaryLocation = await promiseActualBinary( | |||
| process.env.FIREFOX_BINARY || "firefox", | |||
There was a problem hiding this comment.
I would not expect a comma here after the first arg. Seems like Prettier is getting confused?
There was a problem hiding this comment.
Does this sound related? prettier/prettier#2788, and if so, should we change https://github.com/mozilla/shield-studies-addon-utils/pull/119/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R52 and we should maybe change --trailing-comma=all to --trailing-comma=es5?
Trailing Commas
Print trailing commas wherever possible when multi-line. (A single-line array,
for example, never gets trailing commas.)Valid options:
- "none" - No trailing commas.
- "es5" - Trailing commas where valid in ES5 (objects, arrays, etc.)
- "all" - Trailing commas wherever possible (including function arguments). This requires node 8 or a transform.
… use a specific version from npm)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting develop branch, for v5.
This is an updated version of PR #109 (see that PR for general discussion)
It includes the commits for #107 and #118 and should thus not be merged before those are merged (to the develop branch) and this PR is rebased upon the latest develop branch.