Test WEE that changes a pref using an experimental API. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on prior work in the Shield Studies Addon Template repo (mozilla/shield-studies-addon-template#55) and Shield Studies Addon Utils repo (mozilla/shield-studies-addon-utils#120). This was just a proof-of-concept for me to understand the basics of creating experimental APIs for use in WebExtension Experiments (WEEs). This WEE simply sets the "browser.privatebrowsing.autostart" boolean preference to "true" via an experimental "prefchange" WebExtension API.
pdehaan
reviewed
Apr 5, 2018
| }, | ||
|
|
||
| "background": { | ||
| "scripts": ["background.js"] |
There was a problem hiding this comment.
nit: indenting looks a bit off here. But super small micro-nit, since I can run everything through prettier (npm run format) and autoformat and submit a PR.
aswan
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on prior work in the Shield Studies Addon Template repo (mozilla/shield-studies-addon-template#55) and Shield Studies Addon Utils repo (mozilla/shield-studies-addon-utils#120).
This was just a proof-of-concept for me to understand the basics of creating experimental APIs for use in WebExtension Experiments (WEEs).
This WEE simply sets the "browser.privatebrowsing.autostart" boolean preference to "true" via an experimental "prefchange" WebExtension API.
Note: I don't currently use the stub
studyexperimental API (which is where we will put ourStudyUtils.jsmmodule) at all.