Fix tp snipe complex #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
added
Enhancement ⚙️
|
Alright, it's been a very long time, going to test this out. |
Panquesito7
requested changes
Apr 13, 2023
| for request_id, _ in pairs(sent_requests) do | ||
| if request_id ~= "count" then | ||
| local request = request_list[request_id] | ||
| if request.direction == "receiver" then |
There was a problem hiding this comment.
I believe area requests should be shown here as well.
Without the area requests, the formspec is kind of bugged out.
There was a problem hiding this comment.
Will try to take care of this soon 👍
There was a problem hiding this comment.
Cool, thanks. Let me know if you need any help with it. 🙂
Panquesito7
added
High priority ❗
|
Hey. Just checking in: do you need any help? Thanks. 🙂 |
|
Ping. @oversword. |
Panquesito7
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BlockySurvival/issue-tracker#83
Fixes BlockySurvival/issue-tracker#320
Choose between this and #51
This PR fixes the teleport conflicts by allowing for multiple teleport requests, and allowing the user to choose between them via a form
The form can also be manually brought up using the new command
/tpffor "teleport form"The form lists all requests made by the player and to the player, and provides buttons for accepting or denying requests, and cancelling their own requests
To make this possible, I have completely re-thought the way teleport requests are stored, the lists
tp.tpr_list,tp.tphr_list,tp.tpc_listandtp.tpn_listshould no longer be needed. Instead there isrequest_list,sender_listandreceiver_list. Each request gets its own ID and is a unique object, the sender and receiver lists index these IDs by the senders and receivers for easier retrieval later.This allows for multiple TP requests to exist at the same time without overwriting each other
This needs a lot of testing, effectively every function needs to be tested, or at least:
/tpr,/tphr,/tpy,/tpn,/tpc