-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tp snipe simple #48
Fix tp snipe simple #48
Conversation
Could you try to make a simple PR with one branch to test the changes easier and incorporate them easier (if that's fine for you), please? Thanks. |
I would really rather merge the other ones in first, I don't mind waiting for this one, the others were done to make programming this one easier |
Thank you for your contributions! 😄🚀 |
@Panquesito7 Woah woah woah why did you merge this one? Are you sure this is the best fix? Also this one needs to be thoroughly tested, and the user experience considered, I don't think this has been properly reviewed |
Should I revert this one, then? I'm kinda confused... |
This reverts commit 8681019.
Depends on #45
Depends on #46
Depends on #47
(Attempts) to fix the TP sniping issue / the issue with unexpected behaviour
Fixes BlockySurvival/issue-tracker#83
Fixes BlockySurvival/issue-tracker#320
The fix here attempts to allow only one request per user at any time, to avoid any conflicts with multiple requests
These changes definitely need some consideration and testing, I'm unsure if they actually "fix" the problem, I have just attempted to prevent it from happening in the first place.
This the is "simple" solution, I conceived of a more complex solution based on the discussions in BlockySurvival/issue-tracker#83 , but decided to implement this one first as it was faster to write.