Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tp snipe simple #51

Closed
wants to merge 7 commits into from

Conversation

oversword
Copy link
Contributor

@oversword oversword commented Aug 9, 2021

Resurrects #48
Undoes #50
Choose between this and #49

(Attempts) to fix the TP sniping issue / the issue with unexpected behaviour
Fixes BlockySurvival/issue-tracker#83
Fixes BlockySurvival/issue-tracker#320

The fix here attempts to allow only one request per user at any time, to avoid any conflicts with multiple requests

These changes definitely need some consideration and testing, I'm unsure if they actually "fix" the problem, I have just attempted to prevent it from happening in the first place.

This the is "simple" solution, I conceived of a more complex solution based on the discussions in BlockySurvival/issue-tracker#83 , but decided to implement this one first as it was faster to write.

  • These changes may make the mod unpleasant to use, it may feel like it's constantly telling you it's not working
  • This only works if the lists are correctly cleared, something which is not guaranteed, but I may have only seen this happening in the the previous broken states
  • We might also want to send a message to the receiver telling them someone attempted to make another request so they can talk to them after they have cleared their current request

@Panquesito7 Panquesito7 self-requested a review August 9, 2021 01:33
@oversword oversword mentioned this pull request Aug 9, 2021
@oversword oversword marked this pull request as draft August 9, 2021 01:39
@oversword oversword marked this pull request as ready for review August 31, 2021 09:04
@Panquesito7 Panquesito7 added Testing needed ⚠️ Test required before merge and removed Extensive testing needed 🎮 labels Apr 13, 2023
@Panquesito7
Copy link
Member

I believe #49 is a better option: way cleaner and adds more features, IMO.
Will be closing this PR for now. Still, thanks for your efforts and contributions. 🙂

@Panquesito7 Panquesito7 added the Won't add 🚫 This will not be worked on label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ⚙️ New feature or request Testing needed ⚠️ Test required before merge Won't add 🚫 This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teleporting seems to be broken Fix TP snipes
2 participants