MsGraphicsPkg: Correct positioning of trash can icon in Load Option's list box #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
- Adjusted CellTrashcanBounds.Left to be CellBounds->Right - TrashcanHitAreaWidth to ensure the trash can icon is displayed to the right of the list box. - Updated width parameter in SWM_RECT_INIT2 to use TrashcanHitAreaWidth instead of CheckBoxHitAreaWidth for correct dimensions. This resolves the issue of the trash can icon overlapping with the ListBox's checkbox thus ensuring its related operations work correctly. Co-authored-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
personal/julorenz/msbootpolicy/4299663
branch
from
702909e to
c5d7c16
Compare
|
@julorenz117 - Fyi, pushed an update to the PR branch to squash all commits, rebase on latest release/202311, remove comments and correct code formatting to pass CI. |
makubacki
changed the title
makubacki
approved these changes
Aug 21, 2024
apop5
approved these changes
Aug 21, 2024
apop5
pushed a commit
to apop5/mu_plus
that referenced
this pull request
Aug 27, 2024
… Load Option's list box (microsoft#552) Fixes microsoft#554 - Adjusted CellTrashcanBounds.Left to be CellBounds->Right - TrashcanHitAreaWidth to ensure the trash can icon is displayed to the right of the list box. - Updated width parameter in SWM_RECT_INIT2 to use TrashcanHitAreaWidth instead of CheckBoxHitAreaWidth for correct dimensions. This resolves the issue of the trash can icon overlapping with the ListBox's deletable item's checkbox thus ensuring its related operations work correctly: activating/deactivating the Load Option or deleting it. Verified that a Load Option allowed to be deleted, such as 'Windows Boot Manager', can now be deleted by pressing the trash icon in its proper position or activated via its check-box. N/A Co-authored-by: Michael Kubacki <[email protected]>
apop5
pushed a commit
that referenced
this pull request
Aug 27, 2024
… Load Option's list box (#552) Fixes #554 - Adjusted CellTrashcanBounds.Left to be CellBounds->Right - TrashcanHitAreaWidth to ensure the trash can icon is displayed to the right of the list box. - Updated width parameter in SWM_RECT_INIT2 to use TrashcanHitAreaWidth instead of CheckBoxHitAreaWidth for correct dimensions. This resolves the issue of the trash can icon overlapping with the ListBox's deletable item's checkbox thus ensuring its related operations work correctly: activating/deactivating the Load Option or deleting it. Verified that a Load Option allowed to be deleted, such as 'Windows Boot Manager', can now be deleted by pressing the trash icon in its proper position or activated via its check-box. N/A Co-authored-by: Michael Kubacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #554
to ensure the trash can icon is displayed to the right of the list box.
of CheckBoxHitAreaWidth for correct dimensions.
This resolves the issue of the trash can icon overlapping with the ListBox's deletable item's checkbox thus ensuring its related operations work correctly: activating/deactivating the Load Option or deleting it.
How This Was Tested
Verified that a Load Option allowed to be deleted, such as 'Windows Boot Manager', can now be deleted by pressing the trash icon in its proper position or activated via its check-box.
Integration Instructions
N/A