Skip to content

Commit

Permalink
MsGraphicsPkg: Correct positioning of trash can icon in list box
Browse files Browse the repository at this point in the history
- Adjusted CellTrashcanBounds.Left to be CellBounds->Right -
  TrashcanHitAreaWidth to ensure the trash can icon is displayed
  to the right of the list box.
- Updated width parameter in SWM_RECT_INIT2 to use
  TrashcanHitAreaWidth instead of CheckBoxHitAreaWidth for correct
  dimensions.

This resolves the issue of the trash can icon overlapping with the
ListBox's checkbox thus ensuring its related operations work
correctly.

Co-authored-by: Michael Kubacki <[email protected]>
  • Loading branch information
julorenz117 and makubacki committed Aug 21, 2024
1 parent bc5f1f0 commit c5d7c16
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions MsGraphicsPkg/Library/SimpleUIToolKit/ListBox.c
Original file line number Diff line number Diff line change
Expand Up @@ -982,9 +982,9 @@ Ctor (

SWM_RECT_INIT2 (
this->m_pCells[Index].CellTrashcanBounds,
CellBounds->Left,
CellBounds->Right - TrashcanHitAreaWidth,
CellBounds->Top,
CheckBoxHitAreaWidth,
TrashcanHitAreaWidth,
SWM_RECT_HEIGHT (*CellBounds)
);
}
Expand Down

0 comments on commit c5d7c16

Please sign in to comment.