[MsGraphicsPkg] Fix the bounds of the Trashcan within the ListBox #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
approved these changes
Aug 21, 2024
makubacki
reviewed
Aug 21, 2024
There was a problem hiding this comment.
@wenbhou, this is a duplicate of #552.
I initially held off reviewing that PR because it is failing CI, but it appears to just be a Uncrustify issue that I'm happy to fix and push. It has an additional change not here.
Since that was submitted beforehand, are you okay closing this PR in favor that one?
There was a problem hiding this comment.
sure, will close this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#554
Fix the bounds of the Trashcan within the ListBox which was introduced in a447466.
The Trashcan should be shown on the right side of the ListBox, but it is currently showing on the left side and overlapping the checkbox icon.
For details on how to complete to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Tested on Surface Laptop and Pro devices. The Trashcan icon is showing on the right side of the Boot Device List Box.
Integration Instructions
N/A