MSC4142: Remove unintentional intentional mentions in replies #4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tulir Asokan <[email protected]>
tulir
added
proposal
|
Discussion about the issue on the original MSC: #3952 (comment) |
Signed-off-by: Tulir Asokan <[email protected]>
clokep
reviewed
May 9, 2024
turt2live
reviewed
May 10, 2024
There was a problem hiding this comment.
Implementation requirements:
- Client code for the feature - Implement MSC4142: Remove unintentional intentional mentions in replies matrix-react-sdk#12511
- Actively used by users to demonstrate desired behaviour
There was a problem hiding this comment.
Actively used by users to demonstrate desired behaviour
Not entirely sure what that means 🤔 The PR opening comment has an example of the currently specced behavior being undesired, and I think it's relatively obvious that mentioning the user you're replying to is desired
There was a problem hiding this comment.
Notifications have always been a pretty controversial area to be within. Where some folks consider it a bug, others don't.
That requirement is mostly to say it needs opinion from Product-centered folks.
turt2live
added
the
needs-implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Implementations:
This MSC was inspired by an unintentional mention chain in Matrix HQ