Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Implement MSC4142: Remove unintentional intentional mentions in replies #30

Closed

Conversation

tulir
Copy link
Contributor

@tulir tulir commented Sep 11, 2024

Fixes element-hq/element-web#27291
Implements matrix-org/matrix-spec-proposals#4142
Re-opened version of matrix-org/matrix-react-sdk#12511

The current spec is just a recommendation, so following it is not required and this can be merged already before the MSC is accepted. The goal of the MSC is to remove the dumb recommendation from the spec

For context:

  • Old behavior before intentional mentions: reply fallbacks caused replies to mention the sender of the replied-to message, as well as any users explicitly mentioned in the replied-to message
  • Current behavior in Element: replies mention the sender of the replied-to message, as well as all users explicitly or implicitly mentioned in the replied-to message. Implicit mentions includes any mentions from earlier in the reply chain (like the senders of all previous messages and any users ever mentioned in the chain)
  • New behavior after this PR: replies mention the sender of the replied-to message

In all cases, new explicit mentions are also of course included

@tulir tulir requested a review from a team as a code owner September 11, 2024 18:12
@tulir tulir requested review from dbkr and robintown September 11, 2024 18:12
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Sep 11, 2024
@dbkr
Copy link
Member

dbkr commented Sep 12, 2024

I've pinged product over on the issue to ensure this is what we want. Code look fine though. Thanks!

@t3chguy
Copy link
Member

t3chguy commented Oct 16, 2024

We have made the decision to merge matrix-react-sdk into https://github.com/element-hq/element-web - if you are still interested in this contribution please move it to that repository. Closing so it does not remain as a zombie

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentioned by reply to message that mentioned me
4 participants