-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hw 1 solution #2117
base: master
Are you sure you want to change the base?
Hw 1 solution #2117
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package core.basesyntax; | ||
|
||
public class Bulldozer extends Machine { | ||
|
||
@Override | ||
public void doWork() { | ||
System.out.println("Bulldozer started working"); | ||
} | ||
|
||
@Override | ||
public void stopWork() { | ||
System.out.println("Bulldozer stopped working"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly, the message in the |
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package core.basesyntax; | ||
|
||
public class Excavator extends Machine { | ||
|
||
@Override | ||
public void doWork() { | ||
System.out.println("Excavator started working"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The message 'Excavator started working' could be more informative. According to the checklist, it should indicate what type of machine is working. Consider specifying the type of machine in a more descriptive way, for example, 'Excavator is now digging the ground.' |
||
} | ||
|
||
@Override | ||
public void stopWork() { | ||
System.out.println("Excavator stopped working"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly to the start message, the stop message 'Excavator stopped working' could be more informative. Reflect what the Excavator was doing before it stopped, such as 'Excavator has finished digging and is now off.' |
||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,9 @@ | ||||
package core.basesyntax; | ||||
|
||||
public abstract class Machine { | ||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
public abstract void doWork(); | ||||
|
||||
public abstract void stopWork(); | ||||
} | ||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
package core.basesyntax; | ||
|
||
public class MainApp { | ||
|
||
public static void main(String[] args) { | ||
Machine[] array = new Machine[]{new Truck(), new Bulldozer(), new Excavator()}; | ||
for (int i = 0; i < array.length; i++) { | ||
array[i].doWork(); | ||
array[i].stopWork(); | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,15 @@ | ||||
package core.basesyntax; | ||||
|
||||
public class Truck extends Machine { | ||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
@Override | ||||
public void doWork() { | ||||
System.out.println("Truck started working"); | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The message should indicate what type of 'Machine' is working. Consider specifying the type of machine in a more informative way. For example: 'Truck is starting its work.' |
||||
} | ||||
|
||||
@Override | ||||
public void stopWork() { | ||||
System.out.println("Truck stopped working"); | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As with the starting message, the stopping message should also be more informative. For example: 'Truck has finished its work.' |
||||
} | ||||
} | ||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message in the
doWork
method should indicate the type of machine more informatively. Consider adding 'Bulldozer' to the message to clarify which machine is working.