Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw 1 solution #2117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

public class Bulldozer extends Machine {

@Override
public void doWork() {
System.out.println("Bulldozer started working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in the doWork method should indicate the type of machine more informatively. Consider adding 'Bulldozer' to the message to clarify which machine is working.

}

@Override
public void stopWork() {
System.out.println("Bulldozer stopped working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the message in the stopWork method should be more informative by specifying the machine type, in this case, 'Bulldozer'.

}
}
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

public class Excavator extends Machine {

@Override
public void doWork() {
System.out.println("Excavator started working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message 'Excavator started working' could be more informative. According to the checklist, it should indicate what type of machine is working. Consider specifying the type of machine in a more descriptive way, for example, 'Excavator is now digging the ground.'

}

@Override
public void stopWork() {
System.out.println("Excavator stopped working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to the start message, the stop message 'Excavator stopped working' could be more informative. Reflect what the Excavator was doing before it stopped, such as 'Excavator has finished digging and is now off.'

}
}
9 changes: 9 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package core.basesyntax;

public abstract class Machine {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

public abstract void doWork();

public abstract void stopWork();
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

8 changes: 7 additions & 1 deletion src/main/java/core/basesyntax/MainApp.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
package core.basesyntax;

public class MainApp {

public static void main(String[] args) {
Machine[] array = new Machine[]{new Truck(), new Bulldozer(), new Excavator()};
for (int i = 0; i < array.length; i++) {
array[i].doWork();
array[i].stopWork();
}
}
}
15 changes: 15 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package core.basesyntax;

public class Truck extends Machine {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@Override
public void doWork() {
System.out.println("Truck started working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should indicate what type of 'Machine' is working. Consider specifying the type of machine in a more informative way. For example: 'Truck is starting its work.'

}

@Override
public void stopWork() {
System.out.println("Truck stopped working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the starting message, the stopping message should also be more informative. For example: 'Truck has finished its work.'

}
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Loading