Hw 1 solution #2117
Hw 1 solution #2117
Conversation
…d it. Overrode the inherited methods. Used them in main methode.
…d it. Overrode the inherited methods. Used them in main methode.
There was a problem hiding this comment.
Great job on addressing the functionality in your pull request! 👍 All the critical aspects seem to be covered well. However, for future tasks, let's aim to make our status messages even more informative by specifying the machine type and its current action. This will enhance the clarity and maintainability of the code. Keep up the good work! 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Bulldozer started working"); |
There was a problem hiding this comment.
The message in the doWork method should indicate the type of machine more informatively. Consider adding 'Bulldozer' to the message to clarify which machine is working.
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Bulldozer stopped working"); |
There was a problem hiding this comment.
Similarly, the message in the stopWork method should be more informative by specifying the machine type, in this case, 'Bulldozer'.
|
|
||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Excavator started working"); |
There was a problem hiding this comment.
The message 'Excavator started working' could be more informative. According to the checklist, it should indicate what type of machine is working. Consider specifying the type of machine in a more descriptive way, for example, 'Excavator is now digging the ground.'
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Excavator stopped working"); |
There was a problem hiding this comment.
Similarly to the start message, the stop message 'Excavator stopped working' could be more informative. Reflect what the Excavator was doing before it stopped, such as 'Excavator has finished digging and is now off.'
|
|
||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Truck started working"); |
There was a problem hiding this comment.
The message should indicate what type of 'Machine' is working. Consider specifying the type of machine in a more informative way. For example: 'Truck is starting its work.'
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck stopped working"); |
There was a problem hiding this comment.
As with the starting message, the stopping message should also be more informative. For example: 'Truck has finished its work.'
| System.out.println("Truck stopped working"); | ||
| } | ||
| } | ||
|
|
| package core.basesyntax; | ||
|
|
||
| public class Truck extends Machine { | ||
|
|
| package core.basesyntax; | ||
|
|
||
| public abstract class Machine { | ||
|
|
|
|
||
| public abstract void stopWork(); | ||
| } | ||
|
|
No description provided.