[MNO-695][MNOE-773] Api v2 Dashboard missing dependency for KPI Alert Recipients #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
x4d3
commented
Oct 17, 2017
•
x4d3
commented
- Include Recipients in Alerts
- Use update_recipients instead of recipient_id
Closed
ouranos
approved these changes
Nov 3, 2017
| ) | ||
| end | ||
| end | ||
| .flatten | ||
| .flatten |
| @@ -26,8 +26,8 @@ def index | |||
|
|
|||
| begin | |||
| response = MnoEnterprise::ImpacClient.send_get('/api/v2/kpis', attrs, basic_auth: auth) | |||
| # TODO check there was no error, something like | |||
| # return render json: { message: "Unable to retrieve kpis from Impac API | Error #{response.code}" } unless response.success? | |||
| # TODO check there was no error, something like | |||
| @@ -2,5 +2,22 @@ module MnoEnterprise | |||
| class Alert < BaseResource | |||
| property :created_at, type: :time | |||
| property :updated_at, type: :time | |||
| property :kpi_id | |||
There was a problem hiding this comment.
Should the kpi_id be exposed? I thought we were getting rid of the foreign keys
There was a problem hiding this comment.
It should for now, but will be addressed later in #560
ouranos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.