WIP: tenant dashboards #537
Conversation
|
FYI, waiting for #535 to be approved & merged before adding specs for this. |
| @@ -0,0 +1,31 @@ | |||
| module MnoEnterprise::Concerns::Controllers::Jpi::V1::Impac::TenantDashboardsController | |||
There was a problem hiding this comment.
Shouldn't it be an admin controller? I thought this was used to load the admin dashboards in your new section in the admin panel?
There was a problem hiding this comment.
Yes true, this should be in the admin controller
| def dashboards | ||
| @dashboards ||= MnoEnterprise::Dashboard | ||
| .includes(*DASHBOARD_DEPENDENCIES) | ||
| .find(owner_type: 'Mnoe::Tenant') |
There was a problem hiding this comment.
When is the dashboard created with owner_type = 'Mnoe::Tenant'? Is it directly in mnohub?
There was a problem hiding this comment.
As you now know, currently it is not being created, as I got this particular element of the project confused with the SPA and thought that we were also provisioning a dashboard for the tenant.
So for this we need then to add the rest of the tenant_dashboards_controller actions.
|
Replace by: #557 |
@ouranos just FYI, any comments?