[TODO SPECS]: Fix dashboard owner_type forced as User on update #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows concern to be included in different modules
Closed
xaun
changed the title
x4d3
approved these changes
Nov 1, 2017
|
LGTM @ouranos Could you please have a look. We had to full qualify the template in order to reuse the DashboardController Concern in the TenantDashboard (See https://github.com/maestrano/opal-webstore/pull/51) |
|
Closing in favor of #558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Adds:
Waiting for #535 to be merged to add specs.
PR for feature/tenant-dashboards: #555
@ouranos @x4d3 @cesar-tonnoir