Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch mysql2 package for ensuring special characters in mysql password and username when only url is provided in config #539

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

samarpanB
Copy link
Collaborator

@samarpanB samarpanB commented Nov 14, 2023

With mysql latest versions, its mandatory to have special characters in password as per security policy in mysql. But with password having '@' or some other special characters, the encoded url string is not decoded properly. This issue has been discussed in detail here too - sidorares/node-mysql2#1621

Referring to the above PR discussion and its related issues discussion, I have added a patch for the library. I am raising a PR on mysql2 library too. Until my PR is merged, this patch can work and ensure test cases pass.

PR added to mysql2 library - sidorares/node-mysql2#2277

Our CI checks are also failing due to this.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@samarpanB samarpanB changed the title chore: test ci issue chore: patch mysql2 package for ensuring special characters in mysql password and username when only url is provided in config Nov 14, 2023
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samarpanB, thanks for the fix.

@samarpanB samarpanB merged commit c2034d5 into master Nov 15, 2023
6 checks passed
@samarpanB samarpanB deleted the test-ci branch November 15, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants